Radio and RadioGroup: Move to Release Candidate#22819
Merged
Merged
Conversation
khmakoto
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ee9ed8:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
spmonahan
force-pushed
the
radio/move-to-rc
branch
from
e1ffc4d to
9317fb4
Compare
khmakoto
approved these changes
May 4, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 921 | 919 | 5000 | |
| Button | mount | 552 | 552 | 5000 | |
| FluentProvider | mount | 1869 | 1854 | 5000 | |
| FluentProviderWithTheme | mount | 266 | 264 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 234 | 226 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 315 | 288 | 10 | |
| MakeStyles | mount | 1575 | 1583 | 50000 |
spmonahan
force-pushed
the
radio/move-to-rc
branch
from
9317fb4 to
df7a250
Compare
miroslavstastny
approved these changes
May 4, 2022
Contributor
|
you'll need to re-generate *.api.md files.
|
spmonahan
force-pushed
the
radio/move-to-rc
branch
from
df7a250 to
28689b3
Compare
- Export Radio and RadioGroup from @fluentui/react-components - Remove Radio and RadioGroup exports from @fluentui/react-components/unstable - Update RadioGroup story location in Storybook - Update Radio README to demonstrate how to import the controls from react-components
spmonahan
force-pushed
the
radio/move-to-rc
branch
from
5fe1455 to
426ee11
Compare
Updates to @fluentui/[email protected] from @fluentui/[email protected]
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 271111345abe5d3f57bdd77aeaf757cd5fe958f1 (build) |
Contributor
|
I think the upgrade story for the v9 public docsite should also be updated, it currently exports from unstable. |
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-radio: move to release candidate - Export Radio and RadioGroup from @fluentui/react-components - Remove Radio and RadioGroup exports from @fluentui/react-components/unstable - Update RadioGroup story location in Storybook - Update Radio README to demonstrate how to import the controls from react-components * react-components: update api snapshot * react-components: update react-radio package version Updates to @fluentui/[email protected] from @fluentui/[email protected] * vr-tests: update react-radio package version * react-radio: update import path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
RadioandRadioGroupare exported from@fluentui/react-components/unstableNew Behavior
RadioandRadioGroupare exported from@fluentui/react-componentsand not from /unstable@fluentui/react-componentsRelated Issue(s)
Fixes #22680