Input: Writing migration guide from v0 and v8#22780
Merged
Merged
Conversation
Provides a basic example for v8 TextField and v9 Input along with a prop mapping table for the two implementations.
Had text "v9" that should have been "v0".
Adds a basic v0 Input to v9 Input upgrade example along with a prop mapping table.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a150b82:
|
Collaborator
📊 Bundle size report🤖 This report was generated against c45f4a6c3dd09c77ce5f5f5e2926ce9494169e99 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c45f4a6c3dd09c77ce5f5f5e2926ce9494169e99 (build) |
khmakoto
changed the title
ling1726
reviewed
May 3, 2022
ling1726
reviewed
May 3, 2022
| | v8 | v9 | Notes | | ||
| | ---------------------- | ------------------------------------------- | ----------------------------------------------------------------------------------------------------------- | | ||
| | `accessibility` | n/a | | | ||
| | `as` | n/a | | |
Contributor
There was a problem hiding this comment.
The as prop should exist on the v9 Input AFAIK
Contributor
Author
There was a problem hiding this comment.
Technically the as prop exists on v9 but with the way all Slots are defined on Input the element types cannot be changed.
This makes sense to me since I don't think we'd ever want to render anything other than an <input> tag.
ling1726
reviewed
May 3, 2022
ling1726
approved these changes
May 3, 2022
khmakoto
approved these changes
May 3, 2022
micahgodbolt
approved these changes
May 3, 2022
…Input.stories.mdx Co-authored-by: Makoto Morimoto <[email protected]>
…Input.stories.mdx Co-authored-by: Makoto Morimoto <[email protected]>
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-input: add v8->v9 upgrade guide Provides a basic example for v8 TextField and v9 Input along with a prop mapping table for the two implementations. * react-radio: fix typo Had text "v9" that should have been "v0". * react-input: add v0->v9 upgrade guide Adds a basic v0 Input to v9 Input upgrade example along with a prop mapping table. * feedback from pr * Update apps/public-docsite-v9/src/Concepts/Upgrade/FromV8/Components/Input.stories.mdx Co-authored-by: Makoto Morimoto <[email protected]> * Update apps/public-docsite-v9/src/Concepts/Upgrade/FromV0/Components/Input.stories.mdx Co-authored-by: Makoto Morimoto <[email protected]> Co-authored-by: Makoto Morimoto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no upgrade guide for
TextFieldto v9InputInputto v9InputNew Behavior
There is an upgrade guide for
TextFieldto v9InputInputto v9InputRelated Issue(s)
Fixes #22769