Skip to content

react-radio: improve migration guide#22767

Merged
spmonahan merged 1 commit into
microsoft:masterfrom
spmonahan:radio/more-migration
May 3, 2022
Merged

react-radio: improve migration guide#22767
spmonahan merged 1 commit into
microsoft:masterfrom
spmonahan:radio/more-migration

Conversation

@spmonahan

Copy link
Copy Markdown
Contributor

Current Behavior

  • There is some inconsistency between v8 and v9 examples
  • Missed from v8 ChoiceGroupOption -> v9 Radio props

New Behavior

  • Improve consistency between v8 and v9 examples
  • Add more v8->v9 prop mappings for ChoiceGroupOption -> Radio

- Improve consistency between v8 and v9 examples
- Add more v8->v9 prop mappings for ChoiceGroupOption -> Radio
@codesandbox-ci

codesandbox-ci Bot commented May 2, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 068449d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against ace1c2193cbff237cb4cda006dad4ed7f8eb1e74

@size-auditor

size-auditor Bot commented May 2, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ace1c2193cbff237cb4cda006dad4ed7f8eb1e74 (build)

@spmonahan spmonahan merged commit 48dbe4c into microsoft:master May 3, 2022
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
- Improve consistency between v8 and v9 examples
- Add more v8->v9 prop mappings for ChoiceGroupOption -> Radio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants