Skip to content

(chore) Move react-aria, react-alert, react-tabster to react-components subfolder#22710

Merged
TristanWatanabe merged 7 commits into
microsoft:masterfrom
TristanWatanabe:move-teams-prg-pkgs-batch-4
May 2, 2022
Merged

(chore) Move react-aria, react-alert, react-tabster to react-components subfolder#22710
TristanWatanabe merged 7 commits into
microsoft:masterfrom
TristanWatanabe:move-teams-prg-pkgs-batch-4

Conversation

@TristanWatanabe

@TristanWatanabe TristanWatanabe commented Apr 29, 2022

Copy link
Copy Markdown
Member

Changes

  • Moves @fluentui/react-aria, @fluentui/react-alert and @fluentui/react-tabster to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner April 29, 2022 13:04
@TristanWatanabe TristanWatanabe self-assigned this Apr 29, 2022
@codesandbox-ci

codesandbox-ci Bot commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3cbb7e0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 45d7e18b8dd8f9d5a69b2d62c3b5c716268622f2 (build)

@fabricteam

fabricteam commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 890 885 5000
Button mount 563 546 5000
FluentProvider mount 1818 1778 5000
FluentProviderWithTheme mount 272 263 10
FluentProviderWithTheme virtual-rerender 249 242 10
FluentProviderWithTheme virtual-rerender-with-unmount 307 313 10
MakeStyles mount 1555 1603 50000

@fabricteam

fabricteam commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 73.754 kB
22.494 kB
react-badge
Badge		 20.965 kB
6.605 kB
react-badge
CounterBadge		 21.918 kB
6.919 kB
react-badge
PresenceBadge		 22.005 kB
6.582 kB
react-combobox
Combobox		 60.564 kB
20.751 kB
react-divider
Divider		 15.455 kB
5.57 kB
react-overflow
hooks only		 10.792 kB
4.125 kB
react-positioning
usePopper		 23.21 kB
8.084 kB
react-radio
Radio		 23.556 kB
7.898 kB
react-radio
RadioGroup		 8.205 kB
3.516 kB
react-spinbutton
SpinButton		 41.955 kB
11.856 kB
react-spinner
Spinner		 17.292 kB
5.865 kB
react-switch
Switch		 24.401 kB
8.024 kB
react-textarea
Textarea		 20.672 kB
7.07 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.347 kB
7.04 kB
react-theme
Teams: Light theme		 19.792 kB
5.694 kB
react-tooltip
Tooltip		 42.907 kB
14.761 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against 71bae426c9678bb1dae838a067858720a152d009

@fabricteam

fabricteam commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 222 185 1.2:1
ListMinimalPerf.default 607 548 1.11:1
DividerMinimalPerf.default 419 384 1.09:1
LayoutMinimalPerf.default 423 392 1.08:1
AlertMinimalPerf.default 315 294 1.07:1
SkeletonMinimalPerf.default 402 374 1.07:1
CardMinimalPerf.default 659 623 1.06:1
FormMinimalPerf.default 487 459 1.06:1
GridMinimalPerf.default 374 354 1.06:1
LoaderMinimalPerf.default 761 718 1.06:1
RadioGroupMinimalPerf.default 529 499 1.06:1
SegmentMinimalPerf.default 400 378 1.06:1
CarouselMinimalPerf.default 550 526 1.05:1
AvatarMinimalPerf.default 208 200 1.04:1
DropdownManyItemsPerf.default 825 796 1.04:1
TextMinimalPerf.default 395 379 1.04:1
ToolbarMinimalPerf.default 1117 1075 1.04:1
AnimationMinimalPerf.default 624 607 1.03:1
AttachmentSlotsPerf.default 1248 1217 1.03:1
HeaderMinimalPerf.default 414 400 1.03:1
ImageMinimalPerf.default 441 429 1.03:1
ListCommonPerf.default 741 718 1.03:1
ListNestedPerf.default 634 615 1.03:1
ProviderMergeThemesPerf.default 1349 1312 1.03:1
IconMinimalPerf.default 733 709 1.03:1
TreeMinimalPerf.default 929 905 1.03:1
ButtonMinimalPerf.default 193 189 1.02:1
ChatWithPopoverPerf.default 461 450 1.02:1
FlexMinimalPerf.default 330 323 1.02:1
ItemLayoutMinimalPerf.default 1374 1343 1.02:1
MenuButtonMinimalPerf.default 1949 1910 1.02:1
StatusMinimalPerf.default 767 750 1.02:1
TextAreaMinimalPerf.default 552 542 1.02:1
CustomToolbarPrototype.default 2950 2900 1.02:1
ButtonOverridesMissPerf.default 1684 1668 1.01:1
DatepickerMinimalPerf.default 6880 6823 1.01:1
DropdownMinimalPerf.default 3396 3358 1.01:1
MenuMinimalPerf.default 956 946 1.01:1
SliderMinimalPerf.default 1861 1845 1.01:1
TooltipMinimalPerf.default 1241 1228 1.01:1
ChatMinimalPerf.default 848 845 1:1
DialogMinimalPerf.default 850 846 1:1
EmbedMinimalPerf.default 4594 4585 1:1
PopupMinimalPerf.default 686 684 1:1
ProviderMinimalPerf.default 418 417 1:1
RefMinimalPerf.default 249 248 1:1
SplitButtonMinimalPerf.default 4940 4934 1:1
TableMinimalPerf.default 468 467 1:1
VideoMinimalPerf.default 744 741 1:1
AccordionMinimalPerf.default 158 159 0.99:1
ButtonSlotsPerf.default 604 608 0.99:1
ChatDuplicateMessagesPerf.default 327 330 0.99:1
HeaderSlotsPerf.default 885 893 0.99:1
TableManyItemsPerf.default 2253 2265 0.99:1
BoxMinimalPerf.default 366 372 0.98:1
CheckboxMinimalPerf.default 2912 2959 0.98:1
ListWith60ListItems.default 716 733 0.98:1
PortalMinimalPerf.default 181 187 0.97:1
InputMinimalPerf.default 1393 1446 0.96:1
RosterPerf.default 1228 1285 0.96:1
ReactionMinimalPerf.default 416 440 0.95:1
LabelMinimalPerf.default 427 453 0.94:1
AttachmentMinimalPerf.default 186 218 0.85:1

@fabricteam

fabricteam commented Apr 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1013 951 5000
Breadcrumb mount 2801 2761 1000
Checkbox mount 1603 1597 5000
CheckboxBase mount 1404 1377 5000
ChoiceGroup mount 5039 4922 5000
ComboBox mount 1008 993 1000
CommandBar mount 10541 10430 1000
ContextualMenu mount 11119 11245 1000
DefaultButton mount 1213 1179 5000
DetailsRow mount 4064 4077 5000
DetailsRowFast mount 3977 4050 5000
DetailsRowNoStyles mount 3825 3816 5000
Dialog mount 2361 2369 1000
DocumentCardTitle mount 175 178 1000
Dropdown mount 3849 3466 5000
FocusTrapZone mount 1880 1885 5000
FocusZone mount 1848 1844 5000
IconButton mount 1850 1884 5000
Label mount 355 365 5000
Layer mount 3090 3097 5000
Link mount 487 475 5000
MenuButton mount 1607 1568 5000
MessageBar mount 2157 2210 5000
Nav mount 3487 3606 1000
OverflowSet mount 1122 1148 5000
Panel mount 2319 2272 1000
Persona mount 1056 1069 1000
Pivot mount 1468 1520 1000
PrimaryButton mount 1387 1429 5000
Rating mount 8327 8408 5000
SearchBox mount 1435 1388 5000
Shimmer mount 2694 2682 5000
Slider mount 2009 1989 5000
SpinButton mount 5263 5305 5000
Spinner mount 426 450 5000
SplitButton mount 3365 3341 5000
Stack mount 550 563 5000
StackWithIntrinsicChildren mount 2579 2525 5000
StackWithTextChildren mount 5756 5801 5000
SwatchColorPicker mount 12268 12022 5000
TagPicker mount 2855 2823 5000
TeachingBubble mount 87052 91798 5000
Text mount 445 456 5000
TextField mount 1502 1522 5000
ThemeProvider mount 1197 1229 5000
ThemeProvider virtual-rerender 647 624 5000
ThemeProvider virtual-rerender-with-unmount 1965 2023 5000
Toggle mount 826 829 5000
buttonNative mount 131 144 5000

@JustSlone

JustSlone commented Apr 29, 2022

Copy link
Copy Markdown
Collaborator

@rohitpagariya FYI on this move as you might have active work going on regarding react-alert

@TristanWatanabe TristanWatanabe mentioned this pull request May 2, 2022
Closed
23 tasks
@TristanWatanabe TristanWatanabe merged commit 35dc16c into microsoft:master May 2, 2022
@TristanWatanabe TristanWatanabe deleted the move-teams-prg-pkgs-batch-4 branch May 2, 2022 17:37
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
@TristanWatanabe @marwan38
(chore) Move react-aria, react-alert, react-tabster to react-componen…
e1afab3 
…ts subfolder (microsoft#22710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miroslavstastny miroslavstastny miroslavstastny approved these changes
@JustSlone JustSlone JustSlone approved these changes
@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner
+1 more reviewer
@ling1726 ling1726 ling1726 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TristanWatanabe TristanWatanabe

Labels

Area: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TristanWatanabe @fabricteam @JustSlone @miroslavstastny @ling1726