(chore) Move react-provider, react-list, react-toolbar to react-components subfolder by TristanWatanabe · Pull Request #22695 · microsoft/fluentui

TristanWatanabe · 2022-04-28T14:36:58Z

Changes

Moves @fluentui/react-provider, @fluentui/react-list and @fluentui/react-toolbar to react-components common folder using move-packages nx generator.

Related Issue(s)

miroslavstastny · 2022-04-28T14:39:44Z

 - Bump Fluent UI packages to 9.0.0-rc ([PR #21623](https://github.com/microsoft/fluentui/pull/21623) by [email protected])
 - Remove component's shorthandProps array ([PR #21134](https://github.com/microsoft/fluentui/pull/21134) by [email protected])
- BREAKING: Rename component hooks add the suffix _unstable, as their API has not been finalized yet ([PR #21365](https://github.com/microsoft/fluentui/pull/21365) by [email protected])
+- BREAKING: Rename component hooks add the suffix \_unstable, as their API has not been finalized yet ([PR #21365](https://github.com/microsoft/fluentui/pull/21365) by [email protected])


codesandbox-ci · 2022-04-28T14:42:24Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98f56e5:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-04-28T14:48:15Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Button	mount	555	560	5000	Possible regression
FluentProviderWithTheme	mount	293	278	10	Possible regression
FluentProviderWithTheme	virtual-rerender	230	235	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	278	286	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	895	910	5000
Button	mount	555	560	5000	Possible regression
FluentProvider	mount	1925	1832	5000
FluentProviderWithTheme	mount	293	278	10	Possible regression
FluentProviderWithTheme	virtual-rerender	230	235	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	278	286	10	Possible regression
MakeStyles	mount	1547	1546	50000

size-auditor · 2022-04-28T14:49:16Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f65f187799f50793c9263cb299d0426a28cc4e9a (build)

fabricteam · 2022-04-28T14:54:58Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.754 kB` `22.494 kB`
`react-badge` Badge	`20.965 kB` `6.605 kB`
`react-badge` CounterBadge	`21.918 kB` `6.919 kB`
`react-badge` PresenceBadge	`22.005 kB` `6.582 kB`
`react-combobox` Combobox	`60.564 kB` `20.751 kB`
`react-divider` Divider	`15.455 kB` `5.57 kB`
`react-input` Input	`21.775 kB` `7.228 kB`
`react-label` Label	`8.441 kB` `3.541 kB`
`react-link` Link	`11.176 kB` `4.545 kB`
`react-overflow` hooks only	`10.792 kB` `4.125 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-radio` Radio	`23.488 kB` `7.889 kB`
`react-radio` RadioGroup	`8.205 kB` `3.516 kB`
`react-spinbutton` SpinButton	`41.955 kB` `11.856 kB`
`react-spinner` Spinner	`17.224 kB` `5.856 kB`
`react-switch` Switch	`24.333 kB` `8.019 kB`
`react-text` Text - Default	`10.867 kB` `4.269 kB`
`react-text` Text - Wrappers	`14.183 kB` `4.61 kB`
`react-textarea` Textarea	`20.672 kB` `7.07 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.327 kB` `7.041 kB`
`react-theme` Teams: Light theme	`19.772 kB` `5.698 kB`
`react-tooltip` Tooltip	`42.907 kB` `14.761 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against f65f187799f50793c9263cb299d0426a28cc4e9a}

fabricteam · 2022-04-28T14:56:20Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	147	123	1.2:1
TableMinimalPerf.default	330	283	1.17:1
GridMinimalPerf.default	274	239	1.15:1
AccordionMinimalPerf.default	127	112	1.13:1
ImageMinimalPerf.default	304	277	1.1:1
ButtonMinimalPerf.default	143	131	1.09:1
RosterPerf.default	928	852	1.09:1
ChatDuplicateMessagesPerf.default	242	224	1.08:1
LayoutMinimalPerf.default	308	286	1.08:1
PortalMinimalPerf.default	144	134	1.07:1
RefMinimalPerf.default	203	193	1.05:1
CarouselMinimalPerf.default	357	344	1.04:1
FlexMinimalPerf.default	242	232	1.04:1
SkeletonMinimalPerf.default	286	275	1.04:1
AlertMinimalPerf.default	223	216	1.03:1
DividerMinimalPerf.default	300	292	1.03:1
LabelMinimalPerf.default	317	309	1.03:1
ReactionMinimalPerf.default	308	298	1.03:1
TextMinimalPerf.default	286	277	1.03:1
AnimationMinimalPerf.default	462	452	1.02:1
AvatarMinimalPerf.default	162	159	1.02:1
DialogMinimalPerf.default	639	625	1.02:1
HeaderMinimalPerf.default	301	295	1.02:1
ItemLayoutMinimalPerf.default	989	965	1.02:1
ListCommonPerf.default	486	477	1.02:1
MenuMinimalPerf.default	714	702	1.02:1
ToolbarMinimalPerf.default	796	781	1.02:1
ButtonSlotsPerf.default	455	451	1.01:1
DatepickerMinimalPerf.default	4822	4790	1.01:1
DropdownManyItemsPerf.default	570	566	1.01:1
LoaderMinimalPerf.default	573	566	1.01:1
MenuButtonMinimalPerf.default	1388	1378	1.01:1
ProviderMergeThemesPerf.default	1063	1048	1.01:1
RadioGroupMinimalPerf.default	373	371	1.01:1
TableManyItemsPerf.default	1614	1592	1.01:1
TextAreaMinimalPerf.default	400	397	1.01:1
CustomToolbarPrototype.default	2294	2265	1.01:1
BoxMinimalPerf.default	279	280	1:1
CheckboxMinimalPerf.default	2184	2178	1:1
DropdownMinimalPerf.default	2470	2475	1:1
InputMinimalPerf.default	1097	1093	1:1
ListNestedPerf.default	462	460	1:1
SliderMinimalPerf.default	1423	1418	1:1
SplitButtonMinimalPerf.default	3686	3675	1:1
StatusMinimalPerf.default	557	557	1:1
TreeMinimalPerf.default	687	687	1:1
ButtonOverridesMissPerf.default	1246	1262	0.99:1
EmbedMinimalPerf.default	3432	3453	0.99:1
FormMinimalPerf.default	320	323	0.99:1
PopupMinimalPerf.default	510	515	0.99:1
IconMinimalPerf.default	473	479	0.99:1
VideoMinimalPerf.default	527	531	0.99:1
AttachmentSlotsPerf.default	889	906	0.98:1
CardMinimalPerf.default	468	480	0.98:1
HeaderSlotsPerf.default	616	626	0.98:1
ListWith60ListItems.default	540	552	0.98:1
AttachmentMinimalPerf.default	120	124	0.97:1
SegmentMinimalPerf.default	274	282	0.97:1
TooltipMinimalPerf.default	886	914	0.97:1
ChatMinimalPerf.default	597	619	0.96:1
ProviderMinimalPerf.default	322	334	0.96:1
ChatWithPopoverPerf.default	290	322	0.9:1
ListMinimalPerf.default	385	431	0.89:1

fabricteam · 2022-04-28T15:06:03Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	909	983	5000
Breadcrumb	mount	2855	2769	1000
Checkbox	mount	1524	1582	5000
CheckboxBase	mount	1314	1278	5000
ChoiceGroup	mount	5027	4964	5000
ComboBox	mount	998	1050	1000
CommandBar	mount	10842	10849	1000
ContextualMenu	mount	11915	11896	1000
DefaultButton	mount	1214	1194	5000
DetailsRow	mount	4047	4009	5000
DetailsRowFast	mount	4007	4021	5000
DetailsRowNoStyles	mount	3878	3762	5000
Dialog	mount	2406	2287	1000
DocumentCardTitle	mount	193	181	1000
Dropdown	mount	3653	3491	5000
FocusTrapZone	mount	1924	1874	5000
FocusZone	mount	1944	1961	5000
IconButton	mount	1829	1888	5000
Label	mount	357	351	5000
Layer	mount	3032	3063	5000
Link	mount	483	474	5000
MenuButton	mount	1541	1525	5000
MessageBar	mount	2167	2246	5000
Nav	mount	3456	3384	1000
OverflowSet	mount	1093	1111	5000
Panel	mount	2251	2256	1000
Persona	mount	1049	1070	1000
Pivot	mount	1519	1527	1000
PrimaryButton	mount	1357	1390	5000
Rating	mount	8068	8103	5000
SearchBox	mount	1373	1371	5000
Shimmer	mount	2618	2651	5000
Slider	mount	2015	1966	5000
SpinButton	mount	5175	5566	5000
Spinner	mount	446	442	5000
SplitButton	mount	3270	3281	5000
Stack	mount	541	531	5000
StackWithIntrinsicChildren	mount	2367	2362	5000
StackWithTextChildren	mount	5418	5405	5000
SwatchColorPicker	mount	12145	12136	5000
TagPicker	mount	2885	2888	5000
TeachingBubble	mount	95988	96258	5000
Text	mount	437	427	5000
TextField	mount	1510	1515	5000
ThemeProvider	mount	1239	1237	5000
ThemeProvider	virtual-rerender	641	649	5000
ThemeProvider	virtual-rerender-with-unmount	1981	1945	5000
Toggle	mount	833	830	5000
buttonNative	mount	147	136	5000

ghost · 2022-04-28T19:23:00Z

All CLA requirements met.

…nents subfolder (microsoft#22695) * move react-provider * move react-list * move react-toolbar * Change Files * Update API

TristanWatanabe added 5 commits April 28, 2022 07:00

move react-provider

39406a4

move react-list

81c1ced

move react-toolbar

88cdfc7

Change Files

f662b88

Update API

153a410

TristanWatanabe added the Area: Build System label Apr 28, 2022

TristanWatanabe self-assigned this Apr 28, 2022

TristanWatanabe requested review from a team, JustSlone, chpalac, jurokapsiar and ling1726 as code owners April 28, 2022 14:36

TristanWatanabe mentioned this pull request Apr 28, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

miroslavstastny reviewed Apr 28, 2022

View reviewed changes

miroslavstastny approved these changes Apr 28, 2022

View reviewed changes

Hotell approved these changes Apr 28, 2022

View reviewed changes

JustSlone approved these changes Apr 28, 2022

View reviewed changes

Merge branch 'master' into move-teams-prg-pkgs-batch-2

5306974

Merge branch 'master' into move-teams-prg-pkgs-batch-2

98f56e5

TristanWatanabe merged commit 5842ed5 into microsoft:master Apr 29, 2022

TristanWatanabe deleted the move-teams-prg-pkgs-batch-2 branch April 29, 2022 11:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(chore) Move react-provider, react-list, react-toolbar to react-components subfolder#22695

(chore) Move react-provider, react-list, react-toolbar to react-components subfolder#22695
TristanWatanabe merged 7 commits into
microsoft:masterfrom
TristanWatanabe:move-teams-prg-pkgs-batch-2

TristanWatanabe commented Apr 28, 2022

Uh oh!

miroslavstastny Apr 28, 2022

Uh oh!

codesandbox-ci Bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

size-auditor Bot commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 28, 2022 •

edited

Loading

Uh oh!

ghost commented Apr 28, 2022 •

edited by ghost

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TristanWatanabe commented Apr 28, 2022

Changes

Related Issue(s)

Uh oh!

miroslavstastny Apr 28, 2022

Choose a reason for hiding this comment

Uh oh!

codesandbox-ci Bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor Bot commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

ghost commented Apr 28, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codesandbox-ci Bot commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

size-auditor Bot commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

ghost commented Apr 28, 2022 •

edited by ghost

Loading