react-radio: write readme#22676
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc8e40f:
|
Collaborator
📊 Bundle size report🤖 This report was generated against f0764e35df36354a86bcf44912a9bf8756df7ddd |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 794 | 840 | 5000 | |
| Button | mount | 540 | 555 | 5000 | |
| FluentProvider | mount | 1862 | 1766 | 5000 | |
| FluentProviderWithTheme | mount | 234 | 253 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 232 | 207 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 304 | 307 | 10 | |
| MakeStyles | mount | 1507 | 1582 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f0764e35df36354a86bcf44912a9bf8756df7ddd (build) |
6 tasks
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
khmakoto
approved these changes
Apr 27, 2022
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "prerelease", | |||
| "comment": "write readme", | |||
Member
There was a problem hiding this comment.
nit:
Suggested change
| "comment": "write readme", | |
| "comment": "Adding readme.", |
Contributor
Author
There was a problem hiding this comment.
I went back n forth on this but technically it was already added and just written :)
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
react-radioonly had the generated boilerplate readme.New Behavior
react-radionow has a readme with basic usage and links to other relevant information.Related Issue(s)
#19953