chore(react-components): fix build:local task#22664
Conversation
Hotell
changed the title
📊 Bundle size report🤖 This report was generated against f25dc32e6a374734b2326bae277a28021f44bc0e |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 71170a0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f25dc32e6a374734b2326bae277a28021f44bc0e (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 281 | 262 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 894 | 902 | 5000 | |
| Button | mount | 520 | 558 | 5000 | |
| FluentProvider | mount | 1891 | 1950 | 5000 | |
| FluentProviderWithTheme | mount | 291 | 288 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 229 | 233 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 281 | 262 | 10 | Possible regression |
| MakeStyles | mount | 1588 | 1504 | 50000 |
There was a problem hiding this comment.
Thanks for fixing this! I just realized that generator also needs to update the actual build:local script in the package json to account for the new path (i.e. this portion: ./dist/packages/react-avatar/src). I can make a follow up PR to fix this in the move-packages script
|
kk pls (the additional update/fix) do, ty! |
Co-authored-by: Tristan Watanabe <[email protected]>
* chore(react-components): fix build:local task * feat(tools): update api-extractor.local when running move generator * generate change file * fixup! feat(tools): update api-extractor.local when running move generator * Update tools/generators/move-packages/index.ts Co-authored-by: Tristan Watanabe <[email protected]> Co-authored-by: Tristan Watanabe <[email protected]>
4 participants
Current Behavior
react-componentstoreact-componentsparent folderbuild:localis brokenNew Behavior
local:buildworksmovegenerator has been updated to accommodate this behaviour for other packagesreact-componentstsConfig override in api extractor configRelated Issue(s)
Fixes #21910