(chore) Move react-menu, react-popover, react-portal to react-components subfolder#22655
Merged
TristanWatanabe merged 5 commits intoApr 27, 2022
Merged
Conversation
23 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e953f5:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 275f5182f8008016c5bad0c00c38c52474a47b8b (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 900 | 889 | 5000 | |
| Button | mount | 557 | 509 | 5000 | |
| FluentProvider | mount | 2037 | 1997 | 5000 | |
| FluentProviderWithTheme | mount | 264 | 309 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 229 | 214 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 316 | 291 | 10 | |
| MakeStyles | mount | 1564 | 1582 | 50000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 134 | 120 | 1.12:1 |
| AccordionMinimalPerf.default | 125 | 116 | 1.08:1 |
| ButtonMinimalPerf.default | 141 | 133 | 1.06:1 |
| CardMinimalPerf.default | 470 | 449 | 1.05:1 |
| DropdownManyItemsPerf.default | 562 | 536 | 1.05:1 |
| GridMinimalPerf.default | 289 | 274 | 1.05:1 |
| LabelMinimalPerf.default | 320 | 305 | 1.05:1 |
| TreeWith60ListItems.default | 149 | 142 | 1.05:1 |
| AttachmentSlotsPerf.default | 939 | 905 | 1.04:1 |
| AvatarMinimalPerf.default | 159 | 153 | 1.04:1 |
| ProviderMinimalPerf.default | 341 | 328 | 1.04:1 |
| RefMinimalPerf.default | 204 | 196 | 1.04:1 |
| IconMinimalPerf.default | 513 | 492 | 1.04:1 |
| CarouselMinimalPerf.default | 402 | 389 | 1.03:1 |
| ChatMinimalPerf.default | 625 | 607 | 1.03:1 |
| PortalMinimalPerf.default | 144 | 140 | 1.03:1 |
| StatusMinimalPerf.default | 566 | 552 | 1.03:1 |
| ImageMinimalPerf.default | 314 | 307 | 1.02:1 |
| ListCommonPerf.default | 526 | 517 | 1.02:1 |
| ListWith60ListItems.default | 554 | 541 | 1.02:1 |
| LoaderMinimalPerf.default | 575 | 566 | 1.02:1 |
| MenuMinimalPerf.default | 718 | 703 | 1.02:1 |
| RosterPerf.default | 945 | 931 | 1.02:1 |
| RadioGroupMinimalPerf.default | 370 | 361 | 1.02:1 |
| SkeletonMinimalPerf.default | 288 | 281 | 1.02:1 |
| TableManyItemsPerf.default | 1611 | 1586 | 1.02:1 |
| ToolbarMinimalPerf.default | 797 | 784 | 1.02:1 |
| AlertMinimalPerf.default | 228 | 226 | 1.01:1 |
| AnimationMinimalPerf.default | 454 | 449 | 1.01:1 |
| CheckboxMinimalPerf.default | 2288 | 2258 | 1.01:1 |
| DatepickerMinimalPerf.default | 4828 | 4780 | 1.01:1 |
| DividerMinimalPerf.default | 289 | 285 | 1.01:1 |
| FormMinimalPerf.default | 331 | 328 | 1.01:1 |
| HeaderMinimalPerf.default | 289 | 286 | 1.01:1 |
| HeaderSlotsPerf.default | 631 | 624 | 1.01:1 |
| InputMinimalPerf.default | 1096 | 1089 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 999 | 994 | 1.01:1 |
| LayoutMinimalPerf.default | 301 | 298 | 1.01:1 |
| PopupMinimalPerf.default | 521 | 516 | 1.01:1 |
| TextAreaMinimalPerf.default | 397 | 395 | 1.01:1 |
| ChatWithPopoverPerf.default | 305 | 305 | 1:1 |
| EmbedMinimalPerf.default | 3450 | 3450 | 1:1 |
| FlexMinimalPerf.default | 229 | 228 | 1:1 |
| ListNestedPerf.default | 464 | 462 | 1:1 |
| MenuButtonMinimalPerf.default | 1410 | 1406 | 1:1 |
| ProviderMergeThemesPerf.default | 1054 | 1058 | 1:1 |
| ReactionMinimalPerf.default | 310 | 310 | 1:1 |
| SliderMinimalPerf.default | 1412 | 1410 | 1:1 |
| SplitButtonMinimalPerf.default | 3669 | 3654 | 1:1 |
| TableMinimalPerf.default | 333 | 332 | 1:1 |
| TextMinimalPerf.default | 281 | 280 | 1:1 |
| CustomToolbarPrototype.default | 2275 | 2266 | 1:1 |
| TooltipMinimalPerf.default | 900 | 899 | 1:1 |
| TreeMinimalPerf.default | 677 | 674 | 1:1 |
| BoxMinimalPerf.default | 279 | 283 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1256 | 1263 | 0.99:1 |
| DropdownMinimalPerf.default | 2577 | 2591 | 0.99:1 |
| ListMinimalPerf.default | 424 | 427 | 0.99:1 |
| SegmentMinimalPerf.default | 282 | 285 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 241 | 245 | 0.98:1 |
| ButtonSlotsPerf.default | 447 | 463 | 0.97:1 |
| DialogMinimalPerf.default | 616 | 636 | 0.97:1 |
| VideoMinimalPerf.default | 523 | 575 | 0.91:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| buttonNative | mount | 108 | 130 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 775 | 781 | 5000 | |
| Breadcrumb | mount | 2386 | 2317 | 1000 | |
| Checkbox | mount | 1309 | 1278 | 5000 | |
| CheckboxBase | mount | 1098 | 2346 | 5000 | |
| ChoiceGroup | mount | 4111 | 4163 | 5000 | |
| ComboBox | mount | 841 | 902 | 1000 | |
| CommandBar | mount | 9110 | 9174 | 1000 | |
| ContextualMenu | mount | 10571 | 9953 | 1000 | |
| DefaultButton | mount | 990 | 972 | 5000 | |
| DetailsRow | mount | 3313 | 3327 | 5000 | |
| DetailsRowFast | mount | 3314 | 3314 | 5000 | |
| DetailsRowNoStyles | mount | 3134 | 3110 | 5000 | |
| Dialog | mount | 1953 | 1967 | 1000 | |
| DocumentCardTitle | mount | 146 | 154 | 1000 | |
| Dropdown | mount | 2901 | 2842 | 5000 | |
| FocusTrapZone | mount | 1592 | 1607 | 5000 | |
| FocusZone | mount | 1578 | 1578 | 5000 | |
| IconButton | mount | 1541 | 1511 | 5000 | |
| Label | mount | 299 | 304 | 5000 | |
| Layer | mount | 2590 | 2519 | 5000 | |
| Link | mount | 402 | 396 | 5000 | |
| MenuButton | mount | 1294 | 1269 | 5000 | |
| MessageBar | mount | 1854 | 1801 | 5000 | |
| Nav | mount | 2865 | 2888 | 1000 | |
| OverflowSet | mount | 959 | 939 | 5000 | |
| Panel | mount | 1873 | 1865 | 1000 | |
| Persona | mount | 879 | 884 | 1000 | |
| Pivot | mount | 1247 | 1242 | 1000 | |
| PrimaryButton | mount | 1133 | 1107 | 5000 | |
| Rating | mount | 6783 | 6664 | 5000 | |
| SearchBox | mount | 1131 | 1140 | 5000 | |
| Shimmer | mount | 2160 | 2173 | 5000 | |
| Slider | mount | 1695 | 1705 | 5000 | |
| SpinButton | mount | 4607 | 4340 | 5000 | |
| Spinner | mount | 378 | 361 | 5000 | |
| SplitButton | mount | 2732 | 2753 | 5000 | |
| Stack | mount | 454 | 457 | 5000 | |
| StackWithIntrinsicChildren | mount | 1993 | 1962 | 5000 | |
| StackWithTextChildren | mount | 4502 | 4520 | 5000 | |
| SwatchColorPicker | mount | 9970 | 10379 | 5000 | |
| TagPicker | mount | 2333 | 3314 | 5000 | |
| TeachingBubble | mount | 84742 | 84598 | 5000 | |
| Text | mount | 369 | 371 | 5000 | |
| TextField | mount | 1210 | 1201 | 5000 | |
| ThemeProvider | mount | 1023 | 1011 | 5000 | |
| ThemeProvider | virtual-rerender | 565 | 576 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1613 | 1643 | 5000 | |
| Toggle | mount | 686 | 689 | 5000 | |
| buttonNative | mount | 108 | 130 | 5000 | Possible regression |
TristanWatanabe
requested review from
a team,
JustSlone and
jurokapsiar
as code owners
Contributor
|
heads up 💡: I found a bug in our move-generator, so consider to re-run after we merge #22664 |
Hotell
approved these changes
Apr 27, 2022
Member
Author
I just manually updated the |
JustSlone
approved these changes
Apr 27, 2022
bsunderhus
approved these changes
Apr 27, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…nts subfolder (microsoft#22655) * move react-menu * move react-popover * move react-portal * Change Files * update build:local script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
@fluentui/react-menu,@fluentui/react-popoverand@fluentui/react-portalto react-components common folder usingmove-packagesnx generator.Related Issue(s)
Part of #22427