Skip to content

(chore) Move react-select, react-slider, react-tabs to react-components subfolder#22647

Merged
TristanWatanabe merged 6 commits into
microsoft:masterfrom
TristanWatanabe:move-cxe-coastal-pkgs-batch-1
Apr 27, 2022
Merged

(chore) Move react-select, react-slider, react-tabs to react-components subfolder#22647
TristanWatanabe merged 6 commits into
microsoft:masterfrom
TristanWatanabe:move-cxe-coastal-pkgs-batch-1

Conversation

@TristanWatanabe

@TristanWatanabe TristanWatanabe commented Apr 26, 2022

Copy link
Copy Markdown
Member

Changes

  • Moves @fluentui/react-select, @fluentui/react-slider and @fluentui/react-tabs to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

@TristanWatanabe TristanWatanabe mentioned this pull request Apr 26, 2022
Closed
23 tasks
@codesandbox-ci

codesandbox-ci Bot commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0a7d0f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 275f5182f8008016c5bad0c00c38c52474a47b8b (build)

@fabricteam

fabricteam commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 919 908 5000
Button mount 551 575 5000
FluentProvider mount 1984 1971 5000
FluentProviderWithTheme mount 306 304 10
FluentProviderWithTheme virtual-rerender 236 258 10
FluentProviderWithTheme virtual-rerender-with-unmount 295 311 10
MakeStyles mount 1569 1581 50000

@fabricteam

fabricteam commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 73.754 kB
22.494 kB
react-avatar
Avatar		 45.196 kB
13.126 kB
react-badge
Badge		 20.965 kB
6.605 kB
react-badge
CounterBadge		 21.918 kB
6.919 kB
react-badge
PresenceBadge		 22.005 kB
6.582 kB
react-button
Button		 32.408 kB
8.986 kB
react-button
CompoundButton		 38.635 kB
10.146 kB
react-button
MenuButton		 34.175 kB
9.567 kB
react-button
SplitButton		 41.431 kB
10.865 kB
react-button
ToggleButton		 43.31 kB
9.921 kB
react-card
Card - All		 57.884 kB
16.524 kB
react-card
Card		 53.169 kB
15.238 kB
react-card
CardFooter		 7.756 kB
3.299 kB
react-card
CardHeader		 9.321 kB
3.816 kB
react-card
CardPreview		 7.728 kB
3.323 kB
react-combobox
Combobox		 60.564 kB
20.751 kB
react-divider
Divider		 15.455 kB
5.57 kB
react-image
Image		 10.179 kB
3.995 kB
react-input
Input		 21.775 kB
7.228 kB
react-label
Label		 8.441 kB
3.541 kB
react-link
Link		 11.176 kB
4.545 kB
react-menu
Menu (including children components)		 110.192 kB
33.528 kB
react-menu
Menu (including selectable components)		 113.367 kB
33.991 kB
react-popover
Popover		 100.693 kB
30.67 kB
react-portal
Portal		 6.272 kB
2.17 kB
react-positioning
usePopper		 23.21 kB
8.084 kB
react-priority-overflow
hooks only		 10.792 kB
4.125 kB
react-provider
FluentProvider		 14.079 kB
5.274 kB
react-spinbutton
SpinButton		 41.955 kB
11.856 kB
react-spinner
Spinner		 17.224 kB
5.856 kB
react-switch
Switch		 24.333 kB
8.019 kB
react-text
Text - Default		 10.867 kB
4.269 kB
react-text
Text - Wrappers		 14.183 kB
4.61 kB
react-textarea
Textarea		 20.672 kB
7.07 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.098 kB
6.657 kB
react-theme
Teams: Light theme		 18.632 kB
5.317 kB
react-tooltip
Tooltip		 42.907 kB
14.761 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against 275f5182f8008016c5bad0c00c38c52474a47b8b

@fabricteam

fabricteam commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatDuplicateMessagesPerf.default 248 230 1.08:1
AttachmentMinimalPerf.default 131 123 1.07:1
ChatWithPopoverPerf.default 315 296 1.06:1
ButtonMinimalPerf.default 144 137 1.05:1
RefMinimalPerf.default 218 208 1.05:1
IconMinimalPerf.default 545 517 1.05:1
TextMinimalPerf.default 313 300 1.04:1
BoxMinimalPerf.default 303 295 1.03:1
LabelMinimalPerf.default 351 340 1.03:1
LoaderMinimalPerf.default 540 525 1.03:1
PortalMinimalPerf.default 147 143 1.03:1
SegmentMinimalPerf.default 310 301 1.03:1
SkeletonMinimalPerf.default 316 306 1.03:1
AnimationMinimalPerf.default 497 487 1.02:1
ButtonSlotsPerf.default 425 415 1.02:1
LayoutMinimalPerf.default 324 317 1.02:1
ListMinimalPerf.default 468 458 1.02:1
MenuButtonMinimalPerf.default 1394 1370 1.02:1
TextAreaMinimalPerf.default 431 424 1.02:1
ButtonOverridesMissPerf.default 1191 1182 1.01:1
CardMinimalPerf.default 511 504 1.01:1
CarouselMinimalPerf.default 369 364 1.01:1
CheckboxMinimalPerf.default 1959 1943 1.01:1
DatepickerMinimalPerf.default 4896 4869 1.01:1
FlexMinimalPerf.default 252 249 1.01:1
HeaderMinimalPerf.default 317 315 1.01:1
ListNestedPerf.default 483 480 1.01:1
RadioGroupMinimalPerf.default 405 400 1.01:1
SliderMinimalPerf.default 1328 1312 1.01:1
AlertMinimalPerf.default 219 220 1:1
AvatarMinimalPerf.default 168 168 1:1
DialogMinimalPerf.default 689 687 1:1
DropdownMinimalPerf.default 2524 2519 1:1
EmbedMinimalPerf.default 3014 3006 1:1
FormMinimalPerf.default 355 356 1:1
InputMinimalPerf.default 1009 1010 1:1
ListWith60ListItems.default 523 521 1:1
MenuMinimalPerf.default 750 749 1:1
RosterPerf.default 869 866 1:1
PopupMinimalPerf.default 551 553 1:1
ProviderMinimalPerf.default 315 314 1:1
ReactionMinimalPerf.default 328 327 1:1
SplitButtonMinimalPerf.default 3336 3321 1:1
StatusMinimalPerf.default 619 622 1:1
ToolbarMinimalPerf.default 837 836 1:1
TreeMinimalPerf.default 729 727 1:1
AttachmentSlotsPerf.default 857 864 0.99:1
ChatMinimalPerf.default 660 664 0.99:1
DividerMinimalPerf.default 322 324 0.99:1
GridMinimalPerf.default 306 308 0.99:1
HeaderSlotsPerf.default 696 700 0.99:1
ListCommonPerf.default 531 539 0.99:1
ProviderMergeThemesPerf.default 992 1001 0.99:1
CustomToolbarPrototype.default 2202 2222 0.99:1
TooltipMinimalPerf.default 934 941 0.99:1
AccordionMinimalPerf.default 122 124 0.98:1
TableManyItemsPerf.default 1619 1645 0.98:1
TableMinimalPerf.default 356 363 0.98:1
VideoMinimalPerf.default 556 568 0.98:1
DropdownManyItemsPerf.default 555 570 0.97:1
ImageMinimalPerf.default 331 343 0.97:1
ItemLayoutMinimalPerf.default 969 1003 0.97:1
TreeWith60ListItems.default 143 153 0.93:1

@fabricteam

fabricteam commented Apr 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 789 789 5000
Breadcrumb mount 2280 2286 1000
Checkbox mount 1252 1261 5000
CheckboxBase mount 1090 1076 5000
ChoiceGroup mount 3927 3929 5000
ComboBox mount 793 788 1000
CommandBar mount 8811 8786 1000
ContextualMenu mount 9209 9235 1000
DefaultButton mount 968 952 5000
DetailsRow mount 3090 3107 5000
DetailsRowFast mount 3068 3047 5000
DetailsRowNoStyles mount 2870 2910 5000
Dialog mount 1833 1824 1000
DocumentCardTitle mount 152 148 1000
Dropdown mount 2768 2795 5000
FocusTrapZone mount 1502 1521 5000
FocusZone mount 1536 1538 5000
IconButton mount 1405 1403 5000
Label mount 317 316 5000
Layer mount 2580 2577 5000
Link mount 430 430 5000
MenuButton mount 1207 1195 5000
MessageBar mount 1835 1874 5000
Nav mount 2866 2657 1000
OverflowSet mount 1019 988 5000
Panel mount 1797 1817 1000
Persona mount 839 842 1000
Pivot mount 1123 1135 1000
PrimaryButton mount 1080 1117 5000
Rating mount 6720 6720 5000
SearchBox mount 1106 1093 5000
Shimmer mount 2240 2224 5000
Slider mount 1687 1722 5000
SpinButton mount 3935 3900 5000
Spinner mount 386 399 5000
SplitButton mount 2484 2465 5000
Stack mount 487 489 5000
StackWithIntrinsicChildren mount 1862 1847 5000
StackWithTextChildren mount 4647 4628 5000
SwatchColorPicker mount 8990 9023 5000
TagPicker mount 2024 2017 5000
TeachingBubble mount 71256 70486 5000
Text mount 397 406 5000
TextField mount 1143 1170 5000
ThemeProvider mount 955 947 5000
ThemeProvider virtual-rerender 622 628 5000
ThemeProvider virtual-rerender-with-unmount 1444 1471 5000
Toggle mount 720 718 5000
buttonNative mount 113 108 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review April 26, 2022 22:02
@tudorpopams tudorpopams requested a review from Hotell April 27, 2022 12:18
Hotell
Hotell approved these changes Apr 27, 2022
View reviewed changes

@Hotell Hotell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#22655 (comment)

@TristanWatanabe

TristanWatanabe commented Apr 27, 2022

Copy link
Copy Markdown
Member Author

f0a7d0f

Fixed in this commit f0a7d0f

@TristanWatanabe TristanWatanabe merged commit f1c470c into microsoft:master Apr 27, 2022
@TristanWatanabe TristanWatanabe deleted the move-cxe-coastal-pkgs-batch-1 branch April 27, 2022 18:15
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
@TristanWatanabe @marwan38
(chore) Move react-select, react-slider, react-tabs to react-componen…
b474760 
…ts subfolder (microsoft#22647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes
@smhigley smhigley smhigley approved these changes
@JustSlone JustSlone JustSlone approved these changes
@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT
@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt
@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

Assignees

@TristanWatanabe TristanWatanabe

Labels

Area: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TristanWatanabe @fabricteam @Hotell @smhigley @JustSlone @miroslavstastny