(chore) Move @fluentui/react-components to react-components subfolder #22557
Merged
TristanWatanabe merged 42 commits intoApr 26, 2022
Conversation
…cy on fluentui/scripts
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ce7e14:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| BoxMinimalPerf.default | 378 | 313 | 1.21:1 |
| GridMinimalPerf.default | 356 | 316 | 1.13:1 |
| AttachmentSlotsPerf.default | 1165 | 1066 | 1.09:1 |
| ToolbarMinimalPerf.default | 1022 | 949 | 1.08:1 |
| CardMinimalPerf.default | 587 | 549 | 1.07:1 |
| InputMinimalPerf.default | 1392 | 1304 | 1.07:1 |
| LabelMinimalPerf.default | 394 | 369 | 1.07:1 |
| MenuMinimalPerf.default | 928 | 871 | 1.07:1 |
| PortalMinimalPerf.default | 176 | 165 | 1.07:1 |
| ListMinimalPerf.default | 531 | 499 | 1.06:1 |
| CarouselMinimalPerf.default | 489 | 466 | 1.05:1 |
| AccordionMinimalPerf.default | 146 | 141 | 1.04:1 |
| DialogMinimalPerf.default | 792 | 765 | 1.04:1 |
| DropdownMinimalPerf.default | 3187 | 3065 | 1.04:1 |
| HeaderSlotsPerf.default | 778 | 746 | 1.04:1 |
| RadioGroupMinimalPerf.default | 465 | 449 | 1.04:1 |
| TextAreaMinimalPerf.default | 483 | 465 | 1.04:1 |
| TooltipMinimalPerf.default | 1085 | 1048 | 1.04:1 |
| TreeMinimalPerf.default | 855 | 824 | 1.04:1 |
| ButtonOverridesMissPerf.default | 1548 | 1508 | 1.03:1 |
| CheckboxMinimalPerf.default | 2787 | 2699 | 1.03:1 |
| DividerMinimalPerf.default | 348 | 338 | 1.03:1 |
| EmbedMinimalPerf.default | 4175 | 4065 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1193 | 1162 | 1.03:1 |
| ListNestedPerf.default | 538 | 524 | 1.03:1 |
| AlertMinimalPerf.default | 259 | 255 | 1.02:1 |
| AvatarMinimalPerf.default | 200 | 197 | 1.02:1 |
| ButtonSlotsPerf.default | 555 | 546 | 1.02:1 |
| RefMinimalPerf.default | 240 | 235 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4462 | 4363 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 290 | 286 | 1.01:1 |
| ChatWithPopoverPerf.default | 388 | 383 | 1.01:1 |
| FlexMinimalPerf.default | 293 | 290 | 1.01:1 |
| FormMinimalPerf.default | 386 | 382 | 1.01:1 |
| HeaderMinimalPerf.default | 349 | 345 | 1.01:1 |
| SkeletonMinimalPerf.default | 337 | 335 | 1.01:1 |
| StatusMinimalPerf.default | 684 | 677 | 1.01:1 |
| TableMinimalPerf.default | 395 | 391 | 1.01:1 |
| TextMinimalPerf.default | 345 | 343 | 1.01:1 |
| CustomToolbarPrototype.default | 2726 | 2700 | 1.01:1 |
| TreeWith60ListItems.default | 173 | 171 | 1.01:1 |
| DatepickerMinimalPerf.default | 5854 | 5834 | 1:1 |
| MenuButtonMinimalPerf.default | 1685 | 1684 | 1:1 |
| RosterPerf.default | 1066 | 1063 | 1:1 |
| ReactionMinimalPerf.default | 369 | 369 | 1:1 |
| SliderMinimalPerf.default | 1678 | 1676 | 1:1 |
| TableManyItemsPerf.default | 1950 | 1951 | 1:1 |
| VideoMinimalPerf.default | 657 | 654 | 1:1 |
| ListWith60ListItems.default | 652 | 660 | 0.99:1 |
| PopupMinimalPerf.default | 615 | 621 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1274 | 1291 | 0.99:1 |
| ProviderMinimalPerf.default | 406 | 411 | 0.99:1 |
| ChatMinimalPerf.default | 727 | 741 | 0.98:1 |
| IconMinimalPerf.default | 599 | 609 | 0.98:1 |
| ButtonMinimalPerf.default | 157 | 163 | 0.96:1 |
| LoaderMinimalPerf.default | 719 | 752 | 0.96:1 |
| ListCommonPerf.default | 669 | 702 | 0.95:1 |
| SegmentMinimalPerf.default | 329 | 345 | 0.95:1 |
| AttachmentMinimalPerf.default | 144 | 154 | 0.94:1 |
| LayoutMinimalPerf.default | 347 | 369 | 0.94:1 |
| DropdownManyItemsPerf.default | 660 | 706 | 0.93:1 |
| ImageMinimalPerf.default | 361 | 393 | 0.92:1 |
| AnimationMinimalPerf.default | 540 | 626 | 0.86:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 779 | 741 | 5000 | |
| Breadcrumb | mount | 2364 | 2160 | 1000 | |
| Checkbox | mount | 1218 | 1164 | 5000 | |
| CheckboxBase | mount | 1113 | 973 | 5000 | |
| ChoiceGroup | mount | 3866 | 3781 | 5000 | |
| ComboBox | mount | 825 | 854 | 1000 | |
| CommandBar | mount | 8754 | 8802 | 1000 | |
| ContextualMenu | mount | 9836 | 10517 | 1000 | |
| DefaultButton | mount | 972 | 988 | 5000 | |
| DetailsRow | mount | 3166 | 3178 | 5000 | |
| DetailsRowFast | mount | 3199 | 3020 | 5000 | |
| DetailsRowNoStyles | mount | 2927 | 3078 | 5000 | |
| Dialog | mount | 1856 | 1823 | 1000 | |
| DocumentCardTitle | mount | 157 | 150 | 1000 | |
| Dropdown | mount | 2745 | 2646 | 5000 | |
| FocusTrapZone | mount | 1384 | 1605 | 5000 | |
| FocusZone | mount | 1449 | 1541 | 5000 | |
| IconButton | mount | 1458 | 1389 | 5000 | |
| Label | mount | 263 | 300 | 5000 | |
| Layer | mount | 2447 | 2424 | 5000 | |
| Link | mount | 404 | 358 | 5000 | |
| MenuButton | mount | 1207 | 1278 | 5000 | |
| MessageBar | mount | 1613 | 1660 | 5000 | |
| Nav | mount | 2913 | 2560 | 1000 | |
| OverflowSet | mount | 954 | 851 | 5000 | |
| Panel | mount | 1727 | 1782 | 1000 | |
| Persona | mount | 885 | 808 | 1000 | |
| Pivot | mount | 1245 | 1133 | 1000 | |
| PrimaryButton | mount | 1108 | 1120 | 5000 | |
| Rating | mount | 6403 | 6610 | 5000 | |
| SearchBox | mount | 1126 | 1115 | 5000 | |
| Shimmer | mount | 2008 | 2085 | 5000 | |
| Slider | mount | 1472 | 1663 | 5000 | |
| SpinButton | mount | 4061 | 4147 | 5000 | |
| Spinner | mount | 383 | 387 | 5000 | |
| SplitButton | mount | 2695 | 2601 | 5000 | |
| Stack | mount | 398 | 408 | 5000 | |
| StackWithIntrinsicChildren | mount | 1787 | 1845 | 5000 | |
| StackWithTextChildren | mount | 4111 | 4226 | 5000 | |
| SwatchColorPicker | mount | 9860 | 9613 | 5000 | |
| TagPicker | mount | 2219 | 2319 | 5000 | |
| TeachingBubble | mount | 94015 | 50398 | 5000 | |
| Text | mount | 371 | 361 | 5000 | |
| TextField | mount | 1207 | 1193 | 5000 | |
| ThemeProvider | mount | 1033 | 1025 | 5000 | |
| ThemeProvider | virtual-rerender | 572 | 576 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1639 | 1656 | 5000 | |
| Toggle | mount | 700 | 688 | 5000 | |
| buttonNative | mount | 109 | 106 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 283 | 251 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 891 | 914 | 5000 | |
| Button | mount | 551 | 568 | 5000 | |
| FluentProvider | mount | 1910 | 1940 | 5000 | |
| FluentProviderWithTheme | mount | 283 | 251 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 272 | 243 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 319 | 313 | 10 | |
| MakeStyles | mount | 1577 | 1555 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4a2a7dd5dc733cd2db4c868ef5272818c0b735cd (build) |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Hotell
reviewed
Apr 25, 2022
Hotell
left a comment
Hotell
left a comment
Contributor
There was a problem hiding this comment.
👏 our move generator is not handling codeowners updates. for this PR it can be done manually but we should implement that as well.
Member
Author
Thanks for catching this! Being addressed by #22624 |
spmonahan
approved these changes
Apr 26, 2022
GeoffCoxMSFT
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
As per RFC #22506, this PR moves
@fluentui/react-componentsto a new subfolder calledreact-componentswhere all v9 packages will be located.This PR uses the new
move-packagesnx generator (#22506) for the actual package file moves but some manual work were also done to account for the new subfolder workspace along with various path updates in the repo that referencedreact-componentsFixes:
Part of #22427