RFC: Group v9 packages to common folder#22460
Conversation
|
|
||
| ## Detailed Design or Proposal | ||
|
|
||
| 1. Within the packages folder, we should create a new subfolder called `react-components` and move all `@fluentui/react-components` packages to it. |
There was a problem hiding this comment.
Decided to go with the react-components subfolder name just to keep it aligned with how the rfcs folder refers to v9 stuff. Open for suggestions though as I don't particularly like how it's a duplicate of the react-components package name
📊 Bundle size report🤖 This report was generated against d07a94aa25cf00c471a17883bd53f71fc1dc4d25 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 115086c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d07a94aa25cf00c471a17883bd53f71fc1dc4d25 (build) |
|
|
||
| ## Detailed Design or Proposal | ||
|
|
||
| 1. Within the packages folder, we should create a new subfolder called `react-components` and move all `@fluentui/react-components` packages to it. |
There was a problem hiding this comment.
What happens to the react-components package itself? Does it stay there? Or does it get moved to some sub-folder. And if so, what do we call it?
There was a problem hiding this comment.
As currently laid out in the RFC proposal, the react-components package itself would go into the new react-components subfolder since this new folder is supposed to contain all v9 related packages.
7 participants
Currently, all v9 packages live in the
/packagesdirectory of the repo alongside v0, v8 and web-components and it can be confusing to figure out which packages are a part of v9 especially for contributors. While all v9 packages contain thereact-prefix, we can't assume that contributors will know that right off the bat and it's also not always the case as some v8 packages are also prefixed with that (such asreact-chartingorreact-focus). This RFC proposes to move all v9 related components and packages to a commonreact-componentsfolder to make it easier for contributors to find all the v9 info they need.Preview
Part of #22427