Skip to content

chore(react-card): stories cleanup#22451

Merged
theerebuss merged 9 commits into
microsoft:masterfrom
theerebuss:card-cleanup
Apr 12, 2022
Merged

chore(react-card): stories cleanup#22451
theerebuss merged 9 commits into
microsoft:masterfrom
theerebuss:card-cleanup

Conversation

@theerebuss

@theerebuss theerebuss commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

New Behavior

  • Move main story file to inside the stories folder
  • Delete previous Office specific stories used for phase 1
  • Add proper description
  • Unify story names
  • Extract the sample card used in the stories to its own component for reusability

Related Issue(s)

Fixes partially #19336

@codesandbox-ci

codesandbox-ci Bot commented Apr 11, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6646b8f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All
53.619 kB
15.372 kB
react-card
Card
48.904 kB
14.089 kB
react-card
CardFooter
7.686 kB
3.264 kB
react-card
CardHeader
9.251 kB
3.78 kB
react-card
CardPreview
7.658 kB
3.291 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
176.089 kB
49.113 kB
react-components
react-components: FluentProvider & webLightTheme
32.601 kB
10.668 kB
🤖 This report was generated against 65897f7924362a8c8bf581ddca162c8ed4247011

@size-auditor

size-auditor Bot commented Apr 11, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 65897f7924362a8c8bf581ddca162c8ed4247011 (build)

@fabricteam

fabricteam commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1126 1144 5000
Button mount 678 683 5000
FluentProvider mount 2050 2117 5000
FluentProviderWithTheme mount 368 345 10
FluentProviderWithTheme virtual-rerender 287 305 10
FluentProviderWithTheme virtual-rerender-with-unmount 363 363 10
MakeStyles mount 1773 1796 50000

display: 'flex',
flexDirection: 'column',
flexDirection: 'row',
flexWrap: 'wrap',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change layout to a more compact one

@theerebuss theerebuss mentioned this pull request Apr 11, 2022
37 tasks
@theerebuss theerebuss merged commit d07a94a into microsoft:master Apr 12, 2022
@theerebuss theerebuss deleted the card-cleanup branch April 12, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants