Button components: Making root a non-nullable slot#22147
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2ce0af9:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
spmonahan
approved these changes
Mar 18, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f4ed6d116e253769f298f787de8a9461f76184b3 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1062 | 1099 | 5000 | |
| Button | mount | 636 | 634 | 5000 | |
| FluentProvider | mount | 2120 | 2095 | 5000 | |
| FluentProviderWithTheme | mount | 331 | 316 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 260 | 240 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 339 | 356 | 10 | |
| MakeStyles | mount | 1857 | 1883 | 50000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
rootslot ofButtoncomponents is nullable, which should not be the case for anyrootslots.New Behavior
This PR fixes the issue by making the
rootslot of allButtoncomponents non-nullable.Related Issue(s)
Fixes part of #21926