Skip to content

Remove star exports from react-spinbutton#22102

Merged
spmonahan merged 2 commits into
microsoft:masterfrom
spmonahan:spinbutton/remove-star-exports
Mar 17, 2022
Merged

Remove star exports from react-spinbutton#22102
spmonahan merged 2 commits into
microsoft:masterfrom
spmonahan:spinbutton/remove-star-exports

Conversation

@spmonahan

Copy link
Copy Markdown
Contributor

Current Behavior

react-spinbutton has export * from ... in src/index.ts.

New Behavior

react-spinbutton has explicitly named exports in src/index.ts.

Related Issue(s)

#22099

@fabricteam

fabricteam commented Mar 15, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against dff926519f57df390afefee4351fc488bc7c4569

@codesandbox-ci

codesandbox-ci Bot commented Mar 15, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d5535e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Mar 15, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 477b45728732361e02047be15de5113d1e6d01ac (build)

Comment thread packages/react-spinbutton/src/index.ts Outdated
Comment thread packages/react-spinbutton/src/index.ts Outdated
Removes star exports from src/index.ts in the react-spinbutton package.

See: microsoft#22099
@spmonahan spmonahan force-pushed the spinbutton/remove-star-exports branch from 4413447 to 0d5535e Compare March 16, 2022 21:19
@spmonahan spmonahan merged commit 8fdd835 into microsoft:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants