react-utilities: Adding helper type to define slot class names#21933
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e43810e:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f52f47c2c8db89c01f91e8f9b5107f39e4a8c28b (build) |
spmonahan
approved these changes
Mar 3, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1008 | 1026 | 5000 | |
| BaseButton | mount | 1058 | 1062 | 5000 | |
| Breadcrumb | mount | 2814 | 2837 | 1000 | |
| ButtonNext | mount | 541 | 537 | 5000 | |
| Checkbox | mount | 1754 | 1736 | 5000 | |
| CheckboxBase | mount | 1561 | 1512 | 5000 | |
| ChoiceGroup | mount | 5387 | 5403 | 5000 | |
| ComboBox | mount | 1166 | 1090 | 1000 | |
| CommandBar | mount | 10990 | 10923 | 1000 | |
| ContextualMenu | mount | 9154 | 9159 | 1000 | |
| DefaultButton | mount | 1309 | 1316 | 5000 | |
| DetailsRow | mount | 4203 | 4141 | 5000 | |
| DetailsRowFast | mount | 4246 | 4217 | 5000 | |
| DetailsRowNoStyles | mount | 4082 | 4040 | 5000 | |
| Dialog | mount | 2430 | 2457 | 1000 | |
| DocumentCardTitle | mount | 209 | 242 | 1000 | |
| Dropdown | mount | 3635 | 3605 | 5000 | |
| FluentProviderNext | mount | 2003 | 1978 | 5000 | |
| FluentProviderWithTheme | mount | 192 | 186 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 144 | 122 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 214 | 207 | 10 | |
| FocusTrapZone | mount | 2033 | 2056 | 5000 | |
| FocusZone | mount | 1953 | 1981 | 5000 | |
| IconButton | mount | 2035 | 2059 | 5000 | |
| Label | mount | 418 | 410 | 5000 | |
| Layer | mount | 3314 | 3342 | 5000 | |
| Link | mount | 542 | 564 | 5000 | |
| MakeStyles | mount | 1756 | 1765 | 50000 | |
| MenuButton | mount | 1700 | 1697 | 5000 | |
| MessageBar | mount | 2205 | 2176 | 5000 | |
| Nav | mount | 3708 | 3710 | 1000 | |
| OverflowSet | mount | 1243 | 1232 | 5000 | |
| Panel | mount | 2319 | 2297 | 1000 | |
| Persona | mount | 923 | 967 | 1000 | |
| Pivot | mount | 1598 | 1588 | 1000 | |
| PrimaryButton | mount | 1484 | 1449 | 5000 | |
| Rating | mount | 8873 | 8952 | 5000 | |
| SearchBox | mount | 1585 | 1555 | 5000 | |
| Shimmer | mount | 2907 | 2897 | 5000 | |
| Slider | mount | 2217 | 2160 | 5000 | |
| SpinButton | mount | 5500 | 5509 | 5000 | |
| Spinner | mount | 491 | 500 | 5000 | |
| SplitButton | mount | 3550 | 3612 | 5000 | |
| Stack | mount | 640 | 603 | 5000 | |
| StackWithIntrinsicChildren | mount | 2778 | 2780 | 5000 | |
| StackWithTextChildren | mount | 6125 | 6233 | 5000 | |
| SwatchColorPicker | mount | 12864 | 12790 | 5000 | |
| TagPicker | mount | 3028 | 3041 | 5000 | |
| TeachingBubble | mount | 14114 | 14042 | 5000 | |
| Text | mount | 515 | 507 | 5000 | |
| TextField | mount | 1613 | 1635 | 5000 | |
| ThemeProvider | mount | 1316 | 1305 | 5000 | |
| ThemeProvider | virtual-rerender | 697 | 692 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2216 | 2174 | 5000 | |
| Toggle | mount | 947 | 958 | 5000 | |
| buttonNative | mount | 164 | 176 | 5000 |
layershifter
approved these changes
Mar 3, 2022
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR adds a
SlotClassNameshelper type, as specified in RFC #21206, under@fluentui/react-utilitiesto help correctly define the slot class names object for our components, ensuring that all slots have a corresponding class name. This PR also updates theswitchClassNamesobject under@fluentui/react-switchto use this new helper type.Related Issue(s)
Fixes part of #21847.