Skip to content

docs/examples: rename deprecated 'name' property to 'text' to avoid disappearing link upon filtering 🪄#21256

Closed
whalderman wants to merge 1 commit into
microsoft:masterfrom
whalderman:docs-patch-1
Closed

docs/examples: rename deprecated 'name' property to 'text' to avoid disappearing link upon filtering 🪄#21256
whalderman wants to merge 1 commit into
microsoft:masterfrom
whalderman:docs-patch-1

Conversation

@whalderman

@whalderman whalderman commented Jan 12, 2022

Copy link
Copy Markdown

Link for quick reference.
Upon filtering, the "Link click" item in the menu is removed permanently.

@size-auditor

size-auditor Bot commented Jan 12, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 97939a4e5f523b3ef05c815f909819701eee92ea (build)

@ling1726 ling1726 closed this Feb 17, 2022
@ling1726 ling1726 reopened this Feb 17, 2022
@spmonahan

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@spmonahan

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@sopranopillow

sopranopillow commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

Seems like after writing again on the filter and deleting, the text items come back.

@sopranopillow

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@sopranopillow

Copy link
Copy Markdown
Contributor

Hi @whalderman, for some strange reason your PR is failing. I have the exact same PR (#22771) and it does work. If you are interested in contributing, I would recommend maybe closing this PR and opening a new one? I can merge in the draft PR if you don't want to work on this one anymore.

@whalderman

Copy link
Copy Markdown
Author

Hi @sopranopillow - no worries, feel free to just use #22771 👍

@whalderman whalderman closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants