Skip to content

Button: Exporting class names of individual slots#20977

Merged
khmakoto merged 6 commits into
microsoft:masterfrom
khmakoto:exportingAllButtonClassNames
Mar 3, 2022
Merged

Button: Exporting class names of individual slots#20977
khmakoto merged 6 commits into
microsoft:masterfrom
khmakoto:exportingAllButtonClassNames

Conversation

@khmakoto

@khmakoto khmakoto commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Description of changes

This PR exports the class names of individual slots in the Button components so that they are consumable by developers using our components according to what was specified on RFC #21206.

Fixes part of #21926 and part of #21847.

@khmakoto khmakoto requested a review from a team December 8, 2021 21:07
@khmakoto khmakoto requested a review from dzearing as a code owner December 8, 2021 21:07
@khmakoto khmakoto self-assigned this Dec 8, 2021
@fabricteam

fabricteam commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-button
Button		 27.982 kB
8.043 kB		 28.013 kB
8.059 kB		 31 B
16 B
react-button
CompoundButton		 33.246 kB
9.007 kB		 33.336 kB
9.037 kB		 90 B
30 B
react-button
MenuButton		 29.65 kB
8.624 kB		 29.763 kB
8.656 kB		 113 B
32 B
react-button
SplitButton		 36.132 kB
9.835 kB		 36.235 kB
9.857 kB		 103 B
22 B
react-button
ToggleButton		 37.28 kB
8.647 kB		 37.395 kB
8.68 kB		 115 B
33 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 171.936 kB
48.167 kB		 171.967 kB
48.194 kB		 31 B
27 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All		 53.205 kB
15.27 kB
react-card
Card		 48.898 kB
14.083 kB
react-card
CardFooter		 7.653 kB
3.246 kB
react-card
CardHeader		 8.931 kB
3.689 kB
react-card
CardPreview		 7.626 kB
3.272 kB
react-components
react-components: FluentProvider & webLightTheme		 32.526 kB
10.645 kB
🤖 This report was generated against 852bd412ad6a682db9dfa44b7275f23fcaccb298

@size-auditor

size-auditor Bot commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 852bd412ad6a682db9dfa44b7275f23fcaccb298 (build)

@codesandbox-ci

codesandbox-ci Bot commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b85aafc:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Dec 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 856 906 5000
BaseButton mount 952 891 5000
Breadcrumb mount 2578 2352 1000
ButtonNext mount 567 573 5000
Checkbox mount 1418 1375 5000
CheckboxBase mount 1277 1295 5000
ChoiceGroup mount 3910 3997 5000
ComboBox mount 971 1043 1000
CommandBar mount 8846 8621 1000
ContextualMenu mount 14805 15169 1000
DefaultButton mount 1125 1035 5000
DetailsRow mount 3307 3197 5000
DetailsRowFast mount 3116 3330 5000
DetailsRowNoStyles mount 3177 3136 5000
Dialog mount 1967 2059 1000
DocumentCardTitle mount 340 289 1000
Dropdown mount 2770 2852 5000
FluentProviderNext mount 1948 1889 5000
FluentProviderWithTheme mount 304 282 10
FluentProviderWithTheme virtual-rerender 245 267 10
FluentProviderWithTheme virtual-rerender-with-unmount 328 374 10
FocusTrapZone mount 1665 1784 5000
FocusZone mount 1770 1692 5000
IconButton mount 1585 1720 5000
Label mount 461 490 5000
Layer mount 2608 2642 5000
Link mount 549 545 5000
MakeStyles mount 1528 1483 50000
MenuButton mount 1436 1367 5000
MessageBar mount 1748 1688 5000
Nav mount 2941 2955 1000
OverflowSet mount 1017 1043 5000
Panel mount 1964 1976 1000
Persona mount 867 867 1000
Pivot mount 1305 1324 1000
PrimaryButton mount 1183 1252 5000
Rating mount 6458 6447 5000
SearchBox mount 1217 1222 5000
Shimmer mount 2228 2128 5000
Slider mount 1763 1686 5000
SpinButton mount 4175 4216 5000
Spinner mount 528 559 5000
SplitButton mount 2732 2876 5000
Stack mount 614 595 5000
StackWithIntrinsicChildren mount 1994 2011 5000
StackWithTextChildren mount 4245 4496 5000
SwatchColorPicker mount 9689 9924 5000
TagPicker mount 2293 2366 5000
TeachingBubble mount 10975 10877 5000
Text mount 558 528 5000
TextField mount 1346 1416 5000
ThemeProvider mount 1141 1060 5000
ThemeProvider virtual-rerender 661 695 5000
ThemeProvider virtual-rerender-with-unmount 1794 1794 5000
Toggle mount 828 852 5000
buttonNative mount 307 320 5000

@khmakoto khmakoto enabled auto-merge (squash) March 3, 2022 21:59
This was referenced Mar 3, 2022
Closed
Closed
@khmakoto khmakoto merged commit e951d80 into microsoft:master Mar 3, 2022
@khmakoto khmakoto deleted the exportingAllButtonClassNames branch March 3, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spmonahan spmonahan spmonahan approved these changes
@dzearing dzearing Awaiting requested review from dzearing

Assignees

@khmakoto khmakoto

Labels

Component: Button

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khmakoto @fabricteam @spmonahan