chore(Accessibility): Update jest-axe to 5.0.1 by jurokapsiar · Pull Request #20609 · microsoft/fluentui

jurokapsiar · 2021-11-15T07:10:09Z

Description of changes

Update jest-axe to new version to get an updated set of axe-core rules for react-northstar unit tests

DustyTheBot · 2021-11-15T07:18:12Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against b9fc4cc

size-auditor · 2021-11-15T07:25:37Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8b8e00f0d0bf82ee665f63bd33a2f314fc1e0e28 (build)

codesandbox-ci · 2021-11-15T07:30:58Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9fc4cc:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2021-11-15T07:32:40Z

📊 Bundle size report

_{🤖 This report was generated against 8b8e00f0d0bf82ee665f63bd33a2f314fc1e0e28}

fabricteam · 2021-11-15T07:44:33Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1060	1065	5000
BaseButton	mount	1047	1065	5000
Breadcrumb	mount	2790	2779	1000
ButtonNext	mount	665	615	5000
Checkbox	mount	1683	1674	5000
CheckboxBase	mount	1412	1425	5000
ChoiceGroup	mount	4956	4871	5000
ComboBox	mount	1096	1108	1000
CommandBar	mount	10452	10463	1000
ContextualMenu	mount	8687	8797	1000
DefaultButton	mount	1292	1257	5000
DetailsRow	mount	3936	3907	5000
DetailsRowFast	mount	3976	3977	5000
DetailsRowNoStyles	mount	3721	3704	5000
Dialog	mount	2709	2684	1000
DocumentCardTitle	mount	282	280	1000
Dropdown	mount	3351	3368	5000
FluentProviderNext	mount	4333	4275	5000
FluentProviderWithTheme	mount	354	331	10
FluentProviderWithTheme	virtual-rerender	235	231	10
FluentProviderWithTheme	virtual-rerender-with-unmount	391	396	10
FocusTrapZone	mount	1906	1941	5000
FocusZone	mount	2000	1990	5000
IconButton	mount	1889	1898	5000
Label	mount	453	480	5000
Layer	mount	3114	3122	5000
Link	mount	615	596	5000
MakeStyles	mount	2006	1943	50000
MenuButton	mount	1603	1569	5000
MessageBar	mount	2132	2137	5000
Nav	mount	3394	3385	1000
OverflowSet	mount	1271	1280	5000
Panel	mount	2672	2659	1000
Persona	mount	996	951	1000
Pivot	mount	1534	1566	1000
PrimaryButton	mount	1433	1431	5000
Rating	mount	7816	7858	5000
SearchBox	mount	1504	1417	5000
Shimmer	mount	2669	2643	5000
Slider	mount	2127	2091	5000
SpinButton	mount	5215	5224	5000
Spinner	mount	570	564	5000
SplitButton	mount	3338	3318	5000
Stack	mount	660	654	5000
StackWithIntrinsicChildren	mount	1822	1865	5000
StackWithTextChildren	mount	4794	4830	5000
SwatchColorPicker	mount	10764	10679	5000
TagPicker	mount	2697	2973	5000
TeachingBubble	mount	13362	13482	5000
Text	mount	579	563	5000
TextField	mount	1532	1510	5000
ThemeProvider	mount	1361	1362	5000
ThemeProvider	virtual-rerender	734	763	5000
ThemeProvider	virtual-rerender-with-unmount	2025	2075	5000
Toggle	mount	937	924	5000
buttonNative	mount	228	252	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
FormMinimalPerf.default	432	379	1.14:1
RefMinimalPerf.default	261	238	1.1:1
PortalMinimalPerf.default	199	183	1.09:1
TableMinimalPerf.default	415	388	1.07:1
ChatWithPopoverPerf.default	393	372	1.06:1
AccordionMinimalPerf.default	151	144	1.05:1
AvatarMinimalPerf.default	215	205	1.05:1
ChatMinimalPerf.default	695	661	1.05:1
ItemLayoutMinimalPerf.default	1218	1171	1.04:1
IconMinimalPerf.default	625	601	1.04:1
VideoMinimalPerf.default	623	601	1.04:1
DropdownManyItemsPerf.default	704	685	1.03:1
LayoutMinimalPerf.default	369	357	1.03:1
ListWith60ListItems.default	675	658	1.03:1
LoaderMinimalPerf.default	690	668	1.03:1
StatusMinimalPerf.default	697	676	1.03:1
ButtonSlotsPerf.default	556	543	1.02:1
CarouselMinimalPerf.default	477	469	1.02:1
DialogMinimalPerf.default	770	753	1.02:1
DividerMinimalPerf.default	372	363	1.02:1
DropdownMinimalPerf.default	3049	3002	1.02:1
GridMinimalPerf.default	344	337	1.02:1
HeaderMinimalPerf.default	368	361	1.02:1
ProviderMergeThemesPerf.default	1760	1725	1.02:1
SegmentMinimalPerf.default	365	358	1.02:1
TreeMinimalPerf.default	824	810	1.02:1
CheckboxMinimalPerf.default	2742	2727	1.01:1
InputMinimalPerf.default	1314	1298	1.01:1
MenuMinimalPerf.default	854	847	1.01:1
ReactionMinimalPerf.default	395	391	1.01:1
TableManyItemsPerf.default	1927	1900	1.01:1
TextMinimalPerf.default	349	347	1.01:1
TooltipMinimalPerf.default	1040	1029	1.01:1
AttachmentSlotsPerf.default	1078	1079	1:1
ButtonOverridesMissPerf.default	1692	1690	1:1
HeaderSlotsPerf.default	764	761	1:1
ListMinimalPerf.default	507	508	1:1
PopupMinimalPerf.default	610	613	1:1
ProviderMinimalPerf.default	1119	1117	1:1
SkeletonMinimalPerf.default	368	367	1:1
CustomToolbarPrototype.default	4073	4069	1:1
AttachmentMinimalPerf.default	159	160	0.99:1
EmbedMinimalPerf.default	4128	4155	0.99:1
LabelMinimalPerf.default	381	386	0.99:1
MenuButtonMinimalPerf.default	1651	1665	0.99:1
TextAreaMinimalPerf.default	497	500	0.99:1
AnimationMinimalPerf.default	404	412	0.98:1
ButtonMinimalPerf.default	173	177	0.98:1
SliderMinimalPerf.default	1648	1684	0.98:1
SplitButtonMinimalPerf.default	4245	4324	0.98:1
ToolbarMinimalPerf.default	929	946	0.98:1
CardMinimalPerf.default	565	581	0.97:1
DatepickerMinimalPerf.default	5483	5652	0.97:1
ImageMinimalPerf.default	353	365	0.97:1
ListNestedPerf.default	550	567	0.97:1
RosterPerf.default	1171	1202	0.97:1
RadioGroupMinimalPerf.default	447	460	0.97:1
BoxMinimalPerf.default	343	359	0.96:1
ChatDuplicateMessagesPerf.default	302	313	0.96:1
TreeWith60ListItems.default	178	187	0.95:1
AlertMinimalPerf.default	273	289	0.94:1
ListCommonPerf.default	624	662	0.94:1
FlexMinimalPerf.default	281	310	0.91:1

varholak-peter

LGTM 🇮🇷

ecraig12345 · 2021-11-19T21:08:00Z

Hope you don't mind, I pushed an update merging with master and de-duping axe-core versions (and some other modified deps) as much as possible.

react-builder still references axe-core 3, and ideally that should be updated as well, but it looks like some additional work would be required.

* chore(Accessibility): Update jest-axe to 5.0.1 * dedupe axe-core Co-authored-by: Juraj Kapsiar <[email protected]> Co-authored-by: Elizabeth Craig <[email protected]>

chore(Accessibility): Update jest-axe to 5.0.1

8aa2e5a

jurokapsiar requested review from a team, layershifter, ling1726, miroslavstastny and pompomon as code owners November 15, 2021 07:10

msft-fluent-ui-bot assigned khmakoto Nov 15, 2021

Merge branch 'master' into update-jest-axe

99f5c98

varholak-peter approved these changes Nov 19, 2021

View reviewed changes

dedupe axe-core

f96a27e

ecraig12345 approved these changes Nov 19, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/master' into update-jest-axe

b9fc4cc

ling1726 approved these changes Nov 25, 2021

View reviewed changes

jurokapsiar merged commit 281e882 into microsoft:master Nov 25, 2021

jurokapsiar deleted the update-jest-axe branch November 25, 2021 07:57

Hotell mentioned this pull request Nov 26, 2021

dependencies: use single version policy for axe-core #20799

Closed

AtishayMsft mentioned this pull request Jan 15, 2024

Bump jest-axe from 6.0.1 to 8.0.0 #30309

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(Accessibility): Update jest-axe to 5.0.1#20609

chore(Accessibility): Update jest-axe to 5.0.1#20609
jurokapsiar merged 4 commits into
microsoft:masterfrom
jurokapsiar:update-jest-axe

jurokapsiar commented Nov 15, 2021

Uh oh!

DustyTheBot commented Nov 15, 2021 •

edited

Loading

Uh oh!

size-auditor Bot commented Nov 15, 2021 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Nov 15, 2021 •

edited

Loading

Uh oh!

fabricteam commented Nov 15, 2021 •

edited

Loading

Uh oh!

fabricteam commented Nov 15, 2021 •

edited

Loading

Uh oh!

varholak-peter left a comment

Uh oh!

ecraig12345 commented Nov 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

jurokapsiar commented Nov 15, 2021

Description of changes

Uh oh!

DustyTheBot commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor Bot commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci Bot commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

varholak-peter left a comment

Choose a reason for hiding this comment

Uh oh!

ecraig12345 commented Nov 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DustyTheBot commented Nov 15, 2021 •

edited

Loading

size-auditor Bot commented Nov 15, 2021 •

edited

Loading

codesandbox-ci Bot commented Nov 15, 2021 •

edited

Loading

fabricteam commented Nov 15, 2021 •

edited

Loading

fabricteam commented Nov 15, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)