Skip to content

react-card - Move story into stories folder#20051

Merged
theerebuss merged 2 commits into
microsoft:masterfrom
theerebuss:card-move-stories
Oct 4, 2021
Merged

react-card - Move story into stories folder#20051
theerebuss merged 2 commits into
microsoft:masterfrom
theerebuss:card-move-stories

Conversation

@theerebuss

@theerebuss theerebuss commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Implementation of #19827

@theerebuss theerebuss requested a review from a team September 30, 2021 16:14
@fabricteam

fabricteam commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-card
Card - All		 13.471 kB
5.068 kB
react-card
Card		 9.317 kB
3.925 kB
react-card
CardFooter		 8.468 kB
3.557 kB
react-card
CardHeader		 9.695 kB
3.99 kB
react-card
CardPreview		 8.783 kB
3.741 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 161.95 kB
46.181 kB
react-components
react-components: FluentProvider & webLightTheme		 32.188 kB
10.658 kB
🤖 This report was generated against 8398647cf864128b0e63570e11ec09f00a0cf8be

@tringakrasniqi

tringakrasniqi commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

Is the PR complete? Because I think that the apart from moving stories into a folder, also each story within the Card.stories.tsx must go into separate files. And, also it must have a Default stories file.

@codesandbox-ci

codesandbox-ci Bot commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cbc26fe:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@theerebuss theerebuss mentioned this pull request Sep 30, 2021
Closed
37 tasks
@size-auditor

size-auditor Bot commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8398647cf864128b0e63570e11ec09f00a0cf8be (build)

@fabricteam

fabricteam commented Sep 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1060 1047 5000
BaseButton mount 1063 1065 5000
Breadcrumb mount 2852 2859 1000
ButtonNext mount 557 559 5000
Checkbox mount 1694 1799 5000
CheckboxBase mount 1539 1430 5000
ChoiceGroup mount 5316 5351 5000
ComboBox mount 1064 1081 1000
CommandBar mount 10946 11001 1000
ContextualMenu mount 7162 7012 1000
DefaultButton mount 1312 1296 5000
DetailsRow mount 4241 4235 5000
DetailsRowFast mount 4306 4320 5000
DetailsRowNoStyles mount 4097 4080 5000
Dialog mount 2725 2669 1000
DocumentCardTitle mount 199 201 1000
Dropdown mount 3634 3647 5000
FluentProviderNext mount 3588 3543 5000
FluentProviderWithTheme mount 216 230 10
FluentProviderWithTheme virtual-rerender 114 117 10
FluentProviderWithTheme virtual-rerender-with-unmount 242 254 10
FocusTrapZone mount 2058 2005 5000
FocusZone mount 1968 1972 5000
IconButton mount 1977 2014 5000
Label mount 391 389 5000
Layer mount 3232 3259 5000
Link mount 533 547 5000
MakeStyles mount 1977 1929 50000
MenuButton mount 1711 1708 5000
MessageBar mount 2125 2133 5000
Nav mount 3743 3726 1000
OverflowSet mount 1239 1218 5000
Panel mount 2544 2535 1000
Persona mount 962 918 1000
Pivot mount 1558 1582 1000
PrimaryButton mount 1477 1463 5000
Rating mount 8818 8847 5000
SearchBox mount 1531 1536 5000
Shimmer mount 2902 2955 5000
Slider mount 2238 2214 5000
SpinButton mount 5541 5642 5000
Spinner mount 457 490 5000
SplitButton mount 3560 3500 5000
Stack mount 570 566 5000
StackWithIntrinsicChildren mount 1932 1953 5000
StackWithTextChildren mount 5357 5301 5000
SwatchColorPicker mount 11642 11590 5000
Tabs mount 1581 1577 1000
TagPicker mount 3035 3027 5000
TeachingBubble mount 13941 14001 5000
Text mount 507 486 5000
TextField mount 1604 1543 5000
ThemeProvider mount 1269 1268 5000
ThemeProvider virtual-rerender 662 672 5000
ThemeProvider virtual-rerender-with-unmount 2108 2096 5000
Toggle mount 931 940 5000
buttonNative mount 147 152 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
IconMinimalPerf.default 786 676 1.16:1
PortalMinimalPerf.default 214 187 1.14:1
AttachmentMinimalPerf.default 199 179 1.11:1
TreeWith60ListItems.default 217 197 1.1:1
AvatarMinimalPerf.default 241 225 1.07:1
FormMinimalPerf.default 498 465 1.07:1
BoxMinimalPerf.default 413 388 1.06:1
MenuButtonMinimalPerf.default 1940 1830 1.06:1
TableMinimalPerf.default 490 464 1.06:1
ButtonSlotsPerf.default 657 623 1.05:1
GridMinimalPerf.default 405 386 1.05:1
ListWith60ListItems.default 736 702 1.05:1
RosterPerf.default 1409 1342 1.05:1
AccordionMinimalPerf.default 178 171 1.04:1
CarouselMinimalPerf.default 539 518 1.04:1
ChatWithPopoverPerf.default 447 430 1.04:1
FlexMinimalPerf.default 337 323 1.04:1
ItemLayoutMinimalPerf.default 1402 1345 1.04:1
LayoutMinimalPerf.default 414 398 1.04:1
ProviderMinimalPerf.default 1273 1227 1.04:1
AlertMinimalPerf.default 312 304 1.03:1
AnimationMinimalPerf.default 465 452 1.03:1
ChatMinimalPerf.default 754 734 1.03:1
DatepickerMinimalPerf.default 6192 6016 1.03:1
HeaderMinimalPerf.default 451 439 1.03:1
TextMinimalPerf.default 401 390 1.03:1
ToolbarMinimalPerf.default 1083 1054 1.03:1
DialogMinimalPerf.default 869 852 1.02:1
HeaderSlotsPerf.default 874 855 1.02:1
ImageMinimalPerf.default 430 421 1.02:1
InputMinimalPerf.default 1464 1437 1.02:1
ProviderMergeThemesPerf.default 1855 1824 1.02:1
RefMinimalPerf.default 258 254 1.02:1
TextAreaMinimalPerf.default 595 586 1.02:1
AttachmentSlotsPerf.default 1243 1225 1.01:1
ButtonMinimalPerf.default 203 200 1.01:1
ButtonOverridesMissPerf.default 2001 1981 1.01:1
CardMinimalPerf.default 668 659 1.01:1
ListCommonPerf.default 727 718 1.01:1
RadioGroupMinimalPerf.default 529 522 1.01:1
ReactionMinimalPerf.default 444 440 1.01:1
SkeletonMinimalPerf.default 409 404 1.01:1
StatusMinimalPerf.default 769 758 1.01:1
CustomToolbarPrototype.default 4618 4550 1.01:1
TooltipMinimalPerf.default 1173 1162 1.01:1
TreeMinimalPerf.default 954 940 1.01:1
VideoMinimalPerf.default 713 707 1.01:1
DropdownMinimalPerf.default 3449 3459 1:1
LabelMinimalPerf.default 438 437 1:1
ListMinimalPerf.default 582 584 1:1
LoaderMinimalPerf.default 786 788 1:1
PopupMinimalPerf.default 647 644 1:1
SplitButtonMinimalPerf.default 4783 4788 1:1
TableManyItemsPerf.default 2214 2203 1:1
CheckboxMinimalPerf.default 2976 3004 0.99:1
EmbedMinimalPerf.default 4762 4789 0.99:1
SliderMinimalPerf.default 1874 1885 0.99:1
ChatDuplicateMessagesPerf.default 358 364 0.98:1
DropdownManyItemsPerf.default 770 787 0.98:1
MenuMinimalPerf.default 958 973 0.98:1
SegmentMinimalPerf.default 418 425 0.98:1
ListNestedPerf.default 635 653 0.97:1
DividerMinimalPerf.default 423 464 0.91:1

@theerebuss

theerebuss commented Sep 30, 2021

Copy link
Copy Markdown
Contributor Author

Is the PR complete? Because I think that the apart from moving stories into a folder, also each story within the Card.stories.tsx must go into separate files. And, also it must have a Default stories file.

Good point! This was supposed to only address the moving of the stories. Tomorrow I'll address the rest in a different PR

@theerebuss

theerebuss commented Oct 1, 2021

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Oct 1, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@theerebuss theerebuss merged commit 4d8e599 into microsoft:master Oct 4, 2021
@theerebuss theerebuss deleted the card-move-stories branch October 4, 2021 05:09
@Hotell

Hotell commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

curios why are we doing this as that RFC was not merged ?

mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
react-card - Move story into stories folder (microsoft#20051)
824d430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes
+1 more reviewer
@tringakrasniqi tringakrasniqi tringakrasniqi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Card Fluent UI react-components (v9)

Projects

None yet

Milestone

September Project Cycle Q3 2021

Development

Successfully merging this pull request may close these issues.

5 participants

@theerebuss @fabricteam @tringakrasniqi @Hotell @khmakoto