Prevent crashes when searching website nav#20003
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f5adea8:
|
Collaborator
📊 Bundle size report🤖 This report was generated against dafc3b7b7092b9249afe8cb8129e2ea5c111c9c5 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: dafc3b7b7092b9249afe8cb8129e2ea5c111c9c5 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Panel | mount | 2625 | 1573 | 1000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1068 | 1036 | 5000 | |
| BaseButton | mount | 1083 | 1064 | 5000 | |
| Breadcrumb | mount | 2908 | 2910 | 1000 | |
| ButtonNext | mount | 517 | 529 | 5000 | |
| Checkbox | mount | 1809 | 1782 | 5000 | |
| CheckboxBase | mount | 1545 | 1586 | 5000 | |
| ChoiceGroup | mount | 5563 | 5757 | 5000 | |
| ComboBox | mount | 1111 | 1139 | 1000 | |
| CommandBar | mount | 11603 | 11275 | 1000 | |
| ContextualMenu | mount | 7128 | 7134 | 1000 | |
| DefaultButton | mount | 1319 | 1353 | 5000 | |
| DetailsRow | mount | 4338 | 4321 | 5000 | |
| DetailsRowFast | mount | 4349 | 4398 | 5000 | |
| DetailsRowNoStyles | mount | 4165 | 4035 | 5000 | |
| Dialog | mount | 2791 | 2839 | 1000 | |
| DocumentCardTitle | mount | 177 | 185 | 1000 | |
| Dropdown | mount | 3779 | 3805 | 5000 | |
| FluentProviderNext | mount | 7843 | 8008 | 5000 | |
| FluentProviderWithTheme | mount | 387 | 390 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 103 | 114 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 545 | 546 | 10 | |
| FocusTrapZone | mount | 2014 | 2011 | 5000 | |
| FocusZone | mount | 2015 | 2031 | 5000 | |
| IconButton | mount | 2109 | 2007 | 5000 | |
| Label | mount | 386 | 366 | 5000 | |
| Layer | mount | 3566 | 3518 | 5000 | |
| Link | mount | 534 | 531 | 5000 | |
| MakeStyles | mount | 2018 | 2019 | 50000 | |
| MenuButton | mount | 1734 | 1735 | 5000 | |
| MessageBar | mount | 2318 | 2248 | 5000 | |
| Nav | mount | 3748 | 3818 | 1000 | |
| OverflowSet | mount | 1220 | 1255 | 5000 | |
| Panel | mount | 2625 | 1573 | 1000 | Possible regression |
| Persona | mount | 997 | 959 | 1000 | |
| Pivot | mount | 1649 | 1632 | 1000 | |
| PrimaryButton | mount | 1489 | 1499 | 5000 | |
| Rating | mount | 9036 | 9093 | 5000 | |
| SearchBox | mount | 1603 | 1553 | 5000 | |
| Shimmer | mount | 3019 | 2928 | 5000 | |
| Slider | mount | 2263 | 2236 | 5000 | |
| SpinButton | mount | 5753 | 5680 | 5000 | |
| Spinner | mount | 453 | 479 | 5000 | |
| SplitButton | mount | 3650 | 3676 | 5000 | |
| Stack | mount | 582 | 596 | 5000 | |
| StackWithIntrinsicChildren | mount | 2047 | 2044 | 5000 | |
| StackWithTextChildren | mount | 5500 | 5610 | 5000 | |
| SwatchColorPicker | mount | 12093 | 11980 | 5000 | |
| Tabs | mount | 1632 | 1607 | 1000 | |
| TagPicker | mount | 3057 | 2999 | 5000 | |
| TeachingBubble | mount | 14199 | 14314 | 5000 | |
| Text | mount | 481 | 471 | 5000 | |
| TextField | mount | 1645 | 1574 | 5000 | |
| ThemeProvider | mount | 1329 | 1299 | 5000 | |
| ThemeProvider | virtual-rerender | 674 | 674 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2137 | 2132 | 5000 | |
| Toggle | mount | 925 | 961 | 5000 | |
| buttonNative | mount | 123 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| DividerMinimalPerf.default | 483 | 419 | 1.15:1 |
| AnimationMinimalPerf.default | 500 | 459 | 1.09:1 |
| HeaderMinimalPerf.default | 443 | 406 | 1.09:1 |
| PortalMinimalPerf.default | 213 | 195 | 1.09:1 |
| ReactionMinimalPerf.default | 488 | 451 | 1.08:1 |
| RefMinimalPerf.default | 277 | 259 | 1.07:1 |
| TreeWith60ListItems.default | 232 | 217 | 1.07:1 |
| VideoMinimalPerf.default | 795 | 746 | 1.07:1 |
| ButtonSlotsPerf.default | 681 | 642 | 1.06:1 |
| ItemLayoutMinimalPerf.default | 1506 | 1425 | 1.06:1 |
| SegmentMinimalPerf.default | 430 | 407 | 1.06:1 |
| AvatarMinimalPerf.default | 234 | 223 | 1.05:1 |
| BoxMinimalPerf.default | 445 | 423 | 1.05:1 |
| ListCommonPerf.default | 755 | 717 | 1.05:1 |
| TableManyItemsPerf.default | 2422 | 2305 | 1.05:1 |
| DialogMinimalPerf.default | 890 | 859 | 1.04:1 |
| LabelMinimalPerf.default | 469 | 449 | 1.04:1 |
| ListWith60ListItems.default | 779 | 752 | 1.04:1 |
| TableMinimalPerf.default | 483 | 465 | 1.04:1 |
| ButtonMinimalPerf.default | 212 | 206 | 1.03:1 |
| CarouselMinimalPerf.default | 567 | 548 | 1.03:1 |
| DropdownManyItemsPerf.default | 836 | 808 | 1.03:1 |
| FormMinimalPerf.default | 495 | 481 | 1.03:1 |
| ImageMinimalPerf.default | 468 | 453 | 1.03:1 |
| LayoutMinimalPerf.default | 431 | 419 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1949 | 1900 | 1.03:1 |
| RadioGroupMinimalPerf.default | 547 | 531 | 1.03:1 |
| SkeletonMinimalPerf.default | 446 | 435 | 1.03:1 |
| TooltipMinimalPerf.default | 1258 | 1219 | 1.03:1 |
| ButtonOverridesMissPerf.default | 2088 | 2045 | 1.02:1 |
| ChatWithPopoverPerf.default | 451 | 440 | 1.02:1 |
| DropdownMinimalPerf.default | 3595 | 3528 | 1.02:1 |
| ListNestedPerf.default | 696 | 684 | 1.02:1 |
| RosterPerf.default | 1439 | 1415 | 1.02:1 |
| SliderMinimalPerf.default | 1990 | 1958 | 1.02:1 |
| SplitButtonMinimalPerf.default | 5073 | 4958 | 1.02:1 |
| AttachmentSlotsPerf.default | 1264 | 1255 | 1.01:1 |
| DatepickerMinimalPerf.default | 6352 | 6299 | 1.01:1 |
| EmbedMinimalPerf.default | 4905 | 4861 | 1.01:1 |
| HeaderSlotsPerf.default | 904 | 892 | 1.01:1 |
| TextAreaMinimalPerf.default | 621 | 615 | 1.01:1 |
| ToolbarMinimalPerf.default | 1135 | 1125 | 1.01:1 |
| CheckboxMinimalPerf.default | 3155 | 3151 | 1:1 |
| GridMinimalPerf.default | 410 | 408 | 1:1 |
| LoaderMinimalPerf.default | 792 | 794 | 1:1 |
| ProviderMinimalPerf.default | 1288 | 1294 | 1:1 |
| TextMinimalPerf.default | 413 | 411 | 1:1 |
| CardMinimalPerf.default | 662 | 670 | 0.99:1 |
| PopupMinimalPerf.default | 677 | 682 | 0.99:1 |
| CustomToolbarPrototype.default | 4660 | 4724 | 0.99:1 |
| TreeMinimalPerf.default | 947 | 960 | 0.99:1 |
| AlertMinimalPerf.default | 332 | 338 | 0.98:1 |
| AttachmentMinimalPerf.default | 202 | 207 | 0.98:1 |
| InputMinimalPerf.default | 1510 | 1533 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1866 | 1910 | 0.98:1 |
| IconMinimalPerf.default | 765 | 784 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 347 | 358 | 0.97:1 |
| FlexMinimalPerf.default | 341 | 350 | 0.97:1 |
| ListMinimalPerf.default | 595 | 616 | 0.97:1 |
| MenuMinimalPerf.default | 997 | 1023 | 0.97:1 |
| ChatMinimalPerf.default | 758 | 787 | 0.96:1 |
| StatusMinimalPerf.default | 854 | 886 | 0.96:1 |
| AccordionMinimalPerf.default | 185 | 205 | 0.9:1 |
khmakoto
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
The left nav on the
@fluentui/reactwebsite was using a regex to do case-insensitive comparisons against a user-typed search query, which caused problems if the search query happened to contain invalid regex syntax. Switch to using lowercase string comparisons instead.