Fix converged package check for default case#19892
Merged
Merged
Conversation
2 tasks
ling1726
approved these changes
Sep 21, 2021
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 287625f:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ae43b3623e0cff41c6dc55bc17de546d4e138d63 (build) |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 931 | 939 | 5000 | |
| BaseButton | mount | 928 | 928 | 5000 | |
| Breadcrumb | mount | 2624 | 2678 | 1000 | |
| ButtonNext | mount | 443 | 454 | 5000 | |
| Checkbox | mount | 1575 | 1510 | 5000 | |
| CheckboxBase | mount | 1288 | 1295 | 5000 | |
| ChoiceGroup | mount | 4729 | 4832 | 5000 | |
| ComboBox | mount | 967 | 1004 | 1000 | |
| CommandBar | mount | 10319 | 10336 | 1000 | |
| ContextualMenu | mount | 6673 | 6533 | 1000 | |
| DefaultButton | mount | 1120 | 1161 | 5000 | |
| DetailsRow | mount | 3732 | 3762 | 5000 | |
| DetailsRowFast | mount | 3848 | 3829 | 5000 | |
| DetailsRowNoStyles | mount | 3652 | 3589 | 5000 | |
| Dialog | mount | 2470 | 2463 | 1000 | |
| DocumentCardTitle | mount | 146 | 149 | 1000 | |
| Dropdown | mount | 3249 | 3271 | 5000 | |
| FluentProviderNext | mount | 7438 | 7499 | 5000 | |
| FluentProviderWithTheme | mount | 356 | 355 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 78 | 93 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 484 | 484 | 10 | |
| FocusTrapZone | mount | 1774 | 1797 | 5000 | |
| FocusZone | mount | 1812 | 1866 | 5000 | |
| IconButton | mount | 1787 | 1826 | 5000 | |
| Label | mount | 347 | 364 | 5000 | |
| Layer | mount | 2978 | 3069 | 5000 | |
| Link | mount | 455 | 477 | 5000 | |
| MakeStyles | mount | 1832 | 1865 | 50000 | |
| MenuButton | mount | 1506 | 1484 | 5000 | |
| MessageBar | mount | 2048 | 2027 | 5000 | |
| Nav | mount | 3342 | 3346 | 1000 | |
| OverflowSet | mount | 1138 | 1110 | 5000 | |
| Panel | mount | 2353 | 2367 | 1000 | |
| Persona | mount | 833 | 856 | 1000 | |
| Pivot | mount | 1426 | 1434 | 1000 | |
| PrimaryButton | mount | 1283 | 1293 | 5000 | |
| Rating | mount | 7782 | 7712 | 5000 | |
| SearchBox | mount | 1347 | 1328 | 5000 | |
| Shimmer | mount | 2555 | 2569 | 5000 | |
| Slider | mount | 2002 | 2057 | 5000 | |
| SpinButton | mount | 5126 | 5159 | 5000 | |
| Spinner | mount | 440 | 440 | 5000 | |
| SplitButton | mount | 3174 | 3237 | 5000 | |
| Stack | mount | 507 | 494 | 5000 | |
| StackWithIntrinsicChildren | mount | 1634 | 1721 | 5000 | |
| StackWithTextChildren | mount | 4635 | 4701 | 5000 | |
| SwatchColorPicker | mount | 10546 | 10589 | 5000 | |
| Tabs | mount | 1425 | 1445 | 1000 | |
| TagPicker | mount | 2642 | 2622 | 5000 | |
| TeachingBubble | mount | 13379 | 13466 | 5000 | |
| Text | mount | 427 | 442 | 5000 | |
| TextField | mount | 1407 | 1407 | 5000 | |
| ThemeProvider | mount | 1221 | 1182 | 5000 | |
| ThemeProvider | virtual-rerender | 593 | 607 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1920 | 1930 | 5000 | |
| Toggle | mount | 829 | 817 | 5000 | |
| buttonNative | mount | 114 | 123 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 179 | 166 | 1.08:1 |
| ChatWithPopoverPerf.default | 378 | 353 | 1.07:1 |
| ImageMinimalPerf.default | 380 | 356 | 1.07:1 |
| SkeletonMinimalPerf.default | 367 | 346 | 1.06:1 |
| DropdownManyItemsPerf.default | 714 | 681 | 1.05:1 |
| MenuMinimalPerf.default | 894 | 848 | 1.05:1 |
| RefMinimalPerf.default | 245 | 234 | 1.05:1 |
| SegmentMinimalPerf.default | 357 | 340 | 1.05:1 |
| AvatarMinimalPerf.default | 197 | 190 | 1.04:1 |
| DividerMinimalPerf.default | 369 | 354 | 1.04:1 |
| ProviderMergeThemesPerf.default | 1789 | 1722 | 1.04:1 |
| TextMinimalPerf.default | 343 | 329 | 1.04:1 |
| TreeWith60ListItems.default | 190 | 183 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 307 | 299 | 1.03:1 |
| CheckboxMinimalPerf.default | 2800 | 2724 | 1.03:1 |
| DialogMinimalPerf.default | 768 | 745 | 1.03:1 |
| GridMinimalPerf.default | 342 | 333 | 1.03:1 |
| HeaderMinimalPerf.default | 365 | 353 | 1.03:1 |
| ListMinimalPerf.default | 520 | 504 | 1.03:1 |
| ListWith60ListItems.default | 663 | 645 | 1.03:1 |
| PortalMinimalPerf.default | 186 | 181 | 1.03:1 |
| IconMinimalPerf.default | 639 | 620 | 1.03:1 |
| AttachmentSlotsPerf.default | 1106 | 1081 | 1.02:1 |
| InputMinimalPerf.default | 1299 | 1271 | 1.02:1 |
| LabelMinimalPerf.default | 384 | 378 | 1.02:1 |
| LoaderMinimalPerf.default | 705 | 693 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1668 | 1635 | 1.02:1 |
| ReactionMinimalPerf.default | 393 | 384 | 1.02:1 |
| TableManyItemsPerf.default | 1929 | 1893 | 1.02:1 |
| TooltipMinimalPerf.default | 1040 | 1024 | 1.02:1 |
| AlertMinimalPerf.default | 272 | 268 | 1.01:1 |
| CardMinimalPerf.default | 546 | 540 | 1.01:1 |
| DatepickerMinimalPerf.default | 5604 | 5528 | 1.01:1 |
| DropdownMinimalPerf.default | 3213 | 3186 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1235 | 1224 | 1.01:1 |
| PopupMinimalPerf.default | 606 | 601 | 1.01:1 |
| RadioGroupMinimalPerf.default | 442 | 439 | 1.01:1 |
| SliderMinimalPerf.default | 1664 | 1653 | 1.01:1 |
| TextAreaMinimalPerf.default | 492 | 486 | 1.01:1 |
| ToolbarMinimalPerf.default | 951 | 944 | 1.01:1 |
| CarouselMinimalPerf.default | 479 | 477 | 1:1 |
| FormMinimalPerf.default | 417 | 417 | 1:1 |
| SplitButtonMinimalPerf.default | 4271 | 4271 | 1:1 |
| CustomToolbarPrototype.default | 4087 | 4070 | 1:1 |
| AccordionMinimalPerf.default | 142 | 144 | 0.99:1 |
| AttachmentMinimalPerf.default | 161 | 162 | 0.99:1 |
| BoxMinimalPerf.default | 343 | 346 | 0.99:1 |
| EmbedMinimalPerf.default | 4210 | 4269 | 0.99:1 |
| LayoutMinimalPerf.default | 362 | 367 | 0.99:1 |
| ListNestedPerf.default | 563 | 571 | 0.99:1 |
| ProviderMinimalPerf.default | 1086 | 1093 | 0.99:1 |
| TableMinimalPerf.default | 405 | 409 | 0.99:1 |
| TreeMinimalPerf.default | 796 | 801 | 0.99:1 |
| AnimationMinimalPerf.default | 405 | 415 | 0.98:1 |
| ButtonOverridesMissPerf.default | 1754 | 1789 | 0.98:1 |
| ButtonSlotsPerf.default | 545 | 557 | 0.98:1 |
| ChatMinimalPerf.default | 650 | 665 | 0.98:1 |
| HeaderSlotsPerf.default | 743 | 758 | 0.98:1 |
| VideoMinimalPerf.default | 620 | 630 | 0.98:1 |
| FlexMinimalPerf.default | 291 | 299 | 0.97:1 |
| ListCommonPerf.default | 633 | 654 | 0.97:1 |
| StatusMinimalPerf.default | 674 | 699 | 0.96:1 |
| RosterPerf.default | 1119 | 1208 | 0.93:1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
isConvergedPackage, restore handling for the case wherepathOrPackageJsonis undefined so that it defaults toprocess.cwd(). (This will fix codesandbox CI.)