chore(eslint-plugin): Move all usages to devdeps#19832
Merged
ling1726 merged 2 commits intoSep 16, 2021
Merged
Conversation
Moves the eslint-plugin package to devDeps for all packages to avoid having to maintain an extra version group for v9 in microsoft#19799
Collaborator
📊 Bundle size reportUnchanged fixtures
|
ecraig12345
approved these changes
Sep 16, 2021
ecraig12345
left a comment
ecraig12345
left a comment
Member
There was a problem hiding this comment.
This should work, though since those packages are all dev-only you could also just change dependencies to devDependencies all-up. Either way is fine with me.
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: acce502f2396742f77099ad2bfa16247dc06f587 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit edb4445:
|
Contributor
Author
@ecraig12345 it doesn work 😭😭 since eslint will error on the dependencies that are actually used... such as |
ling1726
force-pushed
the
fix/reorganize-dev-dependencies
branch
from
8d3d5be to
edb4445
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 886 | 863 | 5000 | |
| BaseButton | mount | 892 | 848 | 5000 | |
| Breadcrumb | mount | 2578 | 2580 | 1000 | |
| ButtonNext | mount | 441 | 445 | 5000 | |
| Checkbox | mount | 1486 | 1489 | 5000 | |
| CheckboxBase | mount | 1251 | 1244 | 5000 | |
| ChoiceGroup | mount | 4661 | 4661 | 5000 | |
| ComboBox | mount | 990 | 953 | 1000 | |
| CommandBar | mount | 10136 | 10100 | 1000 | |
| ContextualMenu | mount | 6415 | 6473 | 1000 | |
| DefaultButton | mount | 1095 | 1100 | 5000 | |
| DetailsRow | mount | 3732 | 3729 | 5000 | |
| DetailsRowFast | mount | 3655 | 3681 | 5000 | |
| DetailsRowNoStyles | mount | 3500 | 3405 | 5000 | |
| Dialog | mount | 2397 | 2475 | 1000 | |
| DocumentCardTitle | mount | 145 | 142 | 1000 | |
| Dropdown | mount | 3206 | 3187 | 5000 | |
| FluentProviderNext | mount | 7408 | 7314 | 5000 | |
| FluentProviderWithTheme | mount | 345 | 344 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 89 | 97 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 481 | 465 | 10 | |
| FocusTrapZone | mount | 1802 | 1756 | 5000 | |
| FocusZone | mount | 1789 | 1814 | 5000 | |
| IconButton | mount | 1731 | 1733 | 5000 | |
| Label | mount | 336 | 313 | 5000 | |
| Layer | mount | 2939 | 2892 | 5000 | |
| Link | mount | 471 | 459 | 5000 | |
| MakeStyles | mount | 1847 | 1795 | 50000 | |
| MenuButton | mount | 1427 | 1452 | 5000 | |
| MessageBar | mount | 1953 | 2072 | 5000 | |
| Nav | mount | 3217 | 3226 | 1000 | |
| OverflowSet | mount | 1081 | 1083 | 5000 | |
| Panel | mount | 2322 | 2356 | 1000 | |
| Persona | mount | 832 | 838 | 1000 | |
| Pivot | mount | 1384 | 1410 | 1000 | |
| PrimaryButton | mount | 1243 | 1265 | 5000 | |
| Rating | mount | 7546 | 7498 | 5000 | |
| SearchBox | mount | 1285 | 1294 | 5000 | |
| Shimmer | mount | 2492 | 2550 | 5000 | |
| Slider | mount | 1915 | 1907 | 5000 | |
| SpinButton | mount | 4868 | 4922 | 5000 | |
| Spinner | mount | 426 | 426 | 5000 | |
| SplitButton | mount | 3101 | 3084 | 5000 | |
| Stack | mount | 477 | 500 | 5000 | |
| StackWithIntrinsicChildren | mount | 1530 | 1522 | 5000 | |
| StackWithTextChildren | mount | 4450 | 4454 | 5000 | |
| SwatchColorPicker | mount | 10013 | 10098 | 5000 | |
| Tabs | mount | 1352 | 1393 | 1000 | |
| TagPicker | mount | 2472 | 2624 | 5000 | |
| TeachingBubble | mount | 13169 | 13298 | 5000 | |
| Text | mount | 414 | 419 | 5000 | |
| TextField | mount | 1340 | 1324 | 5000 | |
| ThemeProvider | mount | 1137 | 1174 | 5000 | |
| ThemeProvider | virtual-rerender | 611 | 585 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1843 | 1843 | 5000 | |
| Toggle | mount | 797 | 776 | 5000 | |
| buttonNative | mount | 112 | 117 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 173 | 156 | 1.11:1 |
| ChatWithPopoverPerf.default | 379 | 348 | 1.09:1 |
| RefMinimalPerf.default | 236 | 221 | 1.07:1 |
| ButtonSlotsPerf.default | 557 | 526 | 1.06:1 |
| CardMinimalPerf.default | 545 | 514 | 1.06:1 |
| SkeletonMinimalPerf.default | 359 | 338 | 1.06:1 |
| TextMinimalPerf.default | 345 | 327 | 1.06:1 |
| HeaderSlotsPerf.default | 755 | 720 | 1.05:1 |
| IconMinimalPerf.default | 624 | 592 | 1.05:1 |
| ButtonOverridesMissPerf.default | 1714 | 1656 | 1.04:1 |
| AnimationMinimalPerf.default | 415 | 402 | 1.03:1 |
| HeaderMinimalPerf.default | 354 | 344 | 1.03:1 |
| InputMinimalPerf.default | 1268 | 1237 | 1.03:1 |
| ListWith60ListItems.default | 647 | 628 | 1.03:1 |
| PortalMinimalPerf.default | 185 | 179 | 1.03:1 |
| TextAreaMinimalPerf.default | 490 | 474 | 1.03:1 |
| DividerMinimalPerf.default | 353 | 347 | 1.02:1 |
| ProviderMergeThemesPerf.default | 1719 | 1678 | 1.02:1 |
| CustomToolbarPrototype.default | 3868 | 3775 | 1.02:1 |
| AttachmentMinimalPerf.default | 147 | 145 | 1.01:1 |
| CarouselMinimalPerf.default | 449 | 444 | 1.01:1 |
| DropdownManyItemsPerf.default | 679 | 670 | 1.01:1 |
| DropdownMinimalPerf.default | 3079 | 3044 | 1.01:1 |
| FlexMinimalPerf.default | 278 | 276 | 1.01:1 |
| GridMinimalPerf.default | 331 | 327 | 1.01:1 |
| ImageMinimalPerf.default | 373 | 370 | 1.01:1 |
| LabelMinimalPerf.default | 376 | 371 | 1.01:1 |
| LayoutMinimalPerf.default | 362 | 359 | 1.01:1 |
| ListCommonPerf.default | 615 | 608 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1628 | 1616 | 1.01:1 |
| ReactionMinimalPerf.default | 365 | 360 | 1.01:1 |
| StatusMinimalPerf.default | 650 | 645 | 1.01:1 |
| ToolbarMinimalPerf.default | 946 | 938 | 1.01:1 |
| BoxMinimalPerf.default | 330 | 330 | 1:1 |
| ChatMinimalPerf.default | 621 | 624 | 1:1 |
| CheckboxMinimalPerf.default | 2675 | 2684 | 1:1 |
| FormMinimalPerf.default | 386 | 386 | 1:1 |
| ListMinimalPerf.default | 488 | 490 | 1:1 |
| MenuMinimalPerf.default | 819 | 819 | 1:1 |
| ProviderMinimalPerf.default | 998 | 995 | 1:1 |
| SplitButtonMinimalPerf.default | 4065 | 4073 | 1:1 |
| TableManyItemsPerf.default | 1852 | 1844 | 1:1 |
| VideoMinimalPerf.default | 618 | 620 | 1:1 |
| EmbedMinimalPerf.default | 4048 | 4081 | 0.99:1 |
| ListNestedPerf.default | 523 | 529 | 0.99:1 |
| SegmentMinimalPerf.default | 338 | 340 | 0.99:1 |
| TooltipMinimalPerf.default | 993 | 1000 | 0.99:1 |
| TreeMinimalPerf.default | 755 | 763 | 0.99:1 |
| DialogMinimalPerf.default | 733 | 750 | 0.98:1 |
| LoaderMinimalPerf.default | 686 | 700 | 0.98:1 |
| PopupMinimalPerf.default | 583 | 594 | 0.98:1 |
| SliderMinimalPerf.default | 1552 | 1578 | 0.98:1 |
| TableMinimalPerf.default | 398 | 405 | 0.98:1 |
| AttachmentSlotsPerf.default | 1050 | 1088 | 0.97:1 |
| AvatarMinimalPerf.default | 180 | 186 | 0.97:1 |
| RosterPerf.default | 1119 | 1154 | 0.97:1 |
| TreeWith60ListItems.default | 159 | 164 | 0.97:1 |
| AccordionMinimalPerf.default | 144 | 150 | 0.96:1 |
| DatepickerMinimalPerf.default | 5101 | 5311 | 0.96:1 |
| ItemLayoutMinimalPerf.default | 1154 | 1214 | 0.95:1 |
| AlertMinimalPerf.default | 262 | 279 | 0.94:1 |
| RadioGroupMinimalPerf.default | 416 | 443 | 0.94:1 |
| ChatDuplicateMessagesPerf.default | 271 | 292 | 0.93:1 |
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* chore(eslint-plugin): Move all usages to devdeps Moves the eslint-plugin package to devDeps for all packages to avoid having to maintain an extra version group for v9 in microsoft#19799 * use carets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Moves the eslint-plugin package to devDeps for all packages to avoid
having to maintain an extra version group for v9 in #19799
Focus areas to test
(optional)