Experiment/star dev deps by ling1726 · Pull Request #19800 · microsoft/fluentui

ling1726 · 2021-09-15T10:09:14Z

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

Splitting v8/9 releases will have the problem of keeping dev dependencies in sync since the v8 daily release will no longer bump dependency versions in v9. Dev dependencies are shared between v8 and v9 but no actual dependencies are shared. Northstar already uses `*` versions for dev dependencies and since the packages affected are also in the monorepo symlinked this should have no consequence for day to day. By converting all internal dev dependencies to `*` we won't need to bump them anymore.

size-auditor · 2021-09-15T10:53:25Z

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 4225f71

Possible causes

The baseline build 4225f71 is broken
The Size Auditor run for the baseline build 4225f71 was not triggered

Recommendations

Please merge your branch for this Pull request with the latest master build and commit your changes once again

codesandbox-ci · 2021-09-15T10:54:19Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e115b5:

Sandbox	Source
Fluent UI React Starter	Configuration

fabricteam · 2021-09-15T10:54:56Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`55.248 kB` `17.403 kB`
`react-avatar` Avatar	`56.558 kB` `15.66 kB`
`react-badge` Badge	`24.343 kB` `7.165 kB`
`react-badge` CounterBadge	`27.156 kB` `7.851 kB`
`react-badge` PresenseBadge	`237 B` `177 B`
`react-button` Button	`22.932 kB` `6.984 kB`
`react-button` CompoundButton	`28.215 kB` `7.834 kB`
`react-button` MenuButton	`24.733 kB` `7.546 kB`
`react-button` ToggleButton	`32.527 kB` `7.601 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`163.935 kB` `46.761 kB`
`react-components` react-components: FluentProvider & webLightTheme	`35.75 kB` `11.392 kB`
`react-divider` Divider	`15.889 kB` `5.747 kB`
`react-image` Image	`9.882 kB` `3.975 kB`
`react-input` Input	`31.636 kB` `11.312 kB`
`react-label` Label	`9.397 kB` `3.839 kB`
`react-link` Link	`13.718 kB` `5.66 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.59 kB` `3.321 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`22.135 kB` `8.356 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.557 kB` `1.202 kB`
`react-menu` Menu (including children components)	`102.963 kB` `31.313 kB`
`react-menu` Menu (including selectable components)	`105.239 kB` `31.665 kB`
`react-popover` Popover	`100.411 kB` `30.075 kB`
`react-portal` Portal	`6.725 kB` `2.237 kB`
`react-positioning` usePopper	`23.145 kB` `7.942 kB`
`react-provider` FluentProvider	`15.748 kB` `5.773 kB`
`react-slider` Slider	`30.697 kB` `9.75 kB`
`react-switch` Switch	`18.067 kB` `6.181 kB`
`react-text` Text - Default	`11.798 kB` `4.452 kB`
`react-text` Text - Wrappers	`15.414 kB` `4.734 kB`
`react-theme` Teams: all themes	`32.941 kB` `6.674 kB`
`react-theme` Teams: Light theme	`20.247 kB` `5.662 kB`
`react-tooltip` Tooltip	`46.029 kB` `15.655 kB`
`react-utilities` SSRProvider	`213 B` `170 B`

_{🤖 This report was generated against 4225f719b5a348816be5d5ef2bc6743884b6a2fc}

fabricteam · 2021-09-15T11:24:41Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	885	908	5000
BaseButton	mount	895	908	5000
Breadcrumb	mount	2628	2633	1000
ButtonNext	mount	441	452	5000
Checkbox	mount	1567	1494	5000
CheckboxBase	mount	1293	1266	5000
ChoiceGroup	mount	4723	4727	5000
ComboBox	mount	1041	975	1000
CommandBar	mount	10354	10322	1000
ContextualMenu	mount	6623	6548	1000
DefaultButton	mount	1132	1130	5000
DetailsRow	mount	3674	3760	5000
DetailsRowFast	mount	3713	3742	5000
DetailsRowNoStyles	mount	3518	3524	5000
Dialog	mount	2468	2401	1000
DocumentCardTitle	mount	138	141	1000
Dropdown	mount	3255	3251	5000
FluentProviderNext	mount	7511	7537	5000
FluentProviderWithTheme	mount	358	365	10
FluentProviderWithTheme	virtual-rerender	91	95	10
FluentProviderWithTheme	virtual-rerender-with-unmount	509	499	10
FocusTrapZone	mount	1804	1823	5000
FocusZone	mount	1825	1813	5000
IconButton	mount	1767	1738	5000
Label	mount	330	347	5000
Layer	mount	3000	2977	5000
Link	mount	456	476	5000
MakeStyles	mount	1877	1826	50000
MenuButton	mount	1437	1453	5000
MessageBar	mount	2028	2010	5000
Nav	mount	3206	3218	1000
OverflowSet	mount	1091	1077	5000
Panel	mount	2413	2363	1000
Persona	mount	831	839	1000
Pivot	mount	1423	1437	1000
PrimaryButton	mount	1305	1290	5000
Rating	mount	7653	7632	5000
SearchBox	mount	1310	1289	5000
Shimmer	mount	2524	2524	5000
Slider	mount	1990	1964	5000
SpinButton	mount	4943	5006	5000
Spinner	mount	434	422	5000
SplitButton	mount	3183	3230	5000
Stack	mount	495	496	5000
StackWithIntrinsicChildren	mount	1536	1507	5000
StackWithTextChildren	mount	4525	4551	5000
SwatchColorPicker	mount	10356	10115	5000
Tabs	mount	1395	1396	1000
TagPicker	mount	2555	2629	5000
TeachingBubble	mount	13388	13358	5000
Text	mount	415	426	5000
TextField	mount	1392	1392	5000
ThemeProvider	mount	1201	1204	5000
ThemeProvider	virtual-rerender	611	597	5000
ThemeProvider	virtual-rerender-with-unmount	1838	1901	5000
Toggle	mount	805	829	5000
buttonNative	mount	111	105	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	177	164	1.08:1
VideoMinimalPerf.default	652	601	1.08:1
TextAreaMinimalPerf.default	504	470	1.07:1
AttachmentSlotsPerf.default	1085	1028	1.06:1
ButtonSlotsPerf.default	560	529	1.06:1
GridMinimalPerf.default	343	324	1.06:1
AvatarMinimalPerf.default	192	183	1.05:1
DialogMinimalPerf.default	808	769	1.05:1
DropdownManyItemsPerf.default	718	689	1.04:1
SegmentMinimalPerf.default	350	338	1.04:1
SkeletonMinimalPerf.default	355	341	1.04:1
TooltipMinimalPerf.default	1038	1002	1.04:1
TreeWith60ListItems.default	178	171	1.04:1
CardMinimalPerf.default	537	522	1.03:1
CarouselMinimalPerf.default	460	446	1.03:1
ChatDuplicateMessagesPerf.default	298	290	1.03:1
FlexMinimalPerf.default	284	277	1.03:1
FormMinimalPerf.default	401	388	1.03:1
LayoutMinimalPerf.default	359	348	1.03:1
PopupMinimalPerf.default	605	585	1.03:1
TableMinimalPerf.default	404	393	1.03:1
ToolbarMinimalPerf.default	927	901	1.03:1
ChatMinimalPerf.default	643	631	1.02:1
DropdownMinimalPerf.default	3130	3068	1.02:1
HeaderSlotsPerf.default	760	746	1.02:1
ItemLayoutMinimalPerf.default	1216	1191	1.02:1
MenuButtonMinimalPerf.default	1633	1607	1.02:1
ProviderMinimalPerf.default	998	981	1.02:1
RadioGroupMinimalPerf.default	452	442	1.02:1
RefMinimalPerf.default	237	232	1.02:1
StatusMinimalPerf.default	674	663	1.02:1
TableManyItemsPerf.default	1909	1877	1.02:1
TreeMinimalPerf.default	797	785	1.02:1
AnimationMinimalPerf.default	411	407	1.01:1
ButtonOverridesMissPerf.default	1697	1681	1.01:1
DividerMinimalPerf.default	354	352	1.01:1
ListCommonPerf.default	623	615	1.01:1
PortalMinimalPerf.default	181	180	1.01:1
SplitButtonMinimalPerf.default	4099	4067	1.01:1
IconMinimalPerf.default	605	598	1.01:1
ChatWithPopoverPerf.default	355	355	1:1
EmbedMinimalPerf.default	4103	4100	1:1
HeaderMinimalPerf.default	355	355	1:1
ListMinimalPerf.default	519	519	1:1
ListNestedPerf.default	547	545	1:1
MenuMinimalPerf.default	818	820	1:1
ProviderMergeThemesPerf.default	1678	1683	1:1
ReactionMinimalPerf.default	363	364	1:1
CustomToolbarPrototype.default	3863	3853	1:1
AttachmentMinimalPerf.default	157	159	0.99:1
BoxMinimalPerf.default	337	340	0.99:1
CheckboxMinimalPerf.default	2730	2744	0.99:1
InputMinimalPerf.default	1252	1262	0.99:1
SliderMinimalPerf.default	1545	1555	0.99:1
TextMinimalPerf.default	341	345	0.99:1
AccordionMinimalPerf.default	154	157	0.98:1
ListWith60ListItems.default	625	636	0.98:1
LoaderMinimalPerf.default	676	693	0.98:1
ImageMinimalPerf.default	370	382	0.97:1
LabelMinimalPerf.default	379	391	0.97:1
DatepickerMinimalPerf.default	5496	5730	0.96:1
RosterPerf.default	1113	1171	0.95:1
AlertMinimalPerf.default	261	280	0.93:1

…-deps

ling1726 added 3 commits September 15, 2021 11:55

improve logs

6f8a298

improve logging

2e933d8

msft-fluent-ui-bot assigned GeoffCoxMSFT Sep 15, 2021

ling1726 mentioned this pull request Sep 15, 2021

chore(nx-generator): Replace internal dev dependency versions with * #19799

Merged

2 tasks

ling1726 force-pushed the experiment/star-dev-deps branch from 594f1d2 to 02d8c3f Compare September 15, 2021 10:44

ling1726 force-pushed the experiment/star-dev-deps branch from 39b9377 to ac47788 Compare September 15, 2021 12:17

ling1726 added 2 commits September 15, 2021 17:31

update version group

d3beca9

increase readability

b92ef3b

ling1726 commented Sep 15, 2021

View reviewed changes

Comment thread packages/react-conformance-make-styles/package.json Outdated

ling1726 added 6 commits September 16, 2021 21:31

Merge remote-tracking branch 'origin/master' into chore/start-dev-deps

7ab484c

run on all packages for limited deps

3f87685

make configurabl;e

930eb45

remove test-utilites

5958d4b

Update dev deps to *

dc8933a

Change files

b99e27f

ling1726 force-pushed the experiment/star-dev-deps branch from f5f5fa3 to b99e27f Compare September 16, 2021 20:19

ling1726 added 2 commits September 16, 2021 23:02

Merge remote-tracking branch 'origin/master' into experiment/star-dev…

824011b

…-deps

latest master

1e115b5

ling1726 closed this Sep 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Experiment/star dev deps#19800

Experiment/star dev deps#19800
ling1726 wants to merge 13 commits into
microsoft:masterfrom
ling1726:experiment/star-dev-deps

ling1726 commented Sep 15, 2021

Uh oh!

size-auditor Bot commented Sep 15, 2021 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Sep 15, 2021 •

edited

Loading

Uh oh!

fabricteam commented Sep 15, 2021 •

edited

Loading

Uh oh!

fabricteam commented Sep 15, 2021 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ling1726 commented Sep 15, 2021

Pull request checklist

Description of changes

Focus areas to test

Uh oh!

size-auditor Bot commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

codesandbox-ci Bot commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

size-auditor Bot commented Sep 15, 2021 •

edited

Loading

codesandbox-ci Bot commented Sep 15, 2021 •

edited

Loading

fabricteam commented Sep 15, 2021 •

edited

Loading

fabricteam commented Sep 15, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)