Storybook/Export to CodeSandbox#19583
Merged
PeterDraex merged 74 commits intoSep 29, 2021
Merged
Conversation
Co-authored-by: Martin Hochel <[email protected]>
Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: Makoto Morimoto <[email protected]>
Co-authored-by: Makoto Morimoto <[email protected]>
theerebuss
approved these changes
Sep 16, 2021
ling1726
reviewed
Sep 16, 2021
ling1726
approved these changes
Sep 16, 2021
ling1726
left a comment
ling1726
left a comment
Contributor
There was a problem hiding this comment.
Tested the documentation for:
- Menu
- Popover
- Accordion
- Button
Export works fine from what I can see 👍
miroslavstastny
approved these changes
Sep 17, 2021
PeterDraex
force-pushed
the
storybook/export-to-codesandbox
branch
from
cc5a4db to
9f048b9
Compare
9 tasks
1 task
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
Adds a "Open in CodeSandbox" button to stories in Storybook in Docs mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds a "Open in CodeSandbox" button to each Storybook story, when viewed in Docs mode.
Most of the of that facilitates the export is in a Storybook addon, which has its own repository: https://github.com/PeterDraex/storybook-addon-export-to-codesandbox
For export to CodeSandbox to work properly, every story needs to be in its own file. This PR splits
Button.stories.tsxso it could serve as an example to other component owners on how to create proper documentation.TODO in other pull requests
must haves:
nice to haves:
yarn.lockinstead of<9.0.0-alpha.60/latest.md)