Skip to content

react-text scaffolding#18571

Merged
theerebuss merged 11 commits into
microsoft:masterfrom
theerebuss:text-scaffolding
Jun 17, 2021
Merged

react-text scaffolding#18571
theerebuss merged 11 commits into
microsoft:masterfrom
theerebuss:text-scaffolding

Conversation

@theerebuss

@theerebuss theerebuss commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Removing previous implementation and re-scaffolding of the package and the Text component

André Dias and others added 2 commits June 15, 2021 16:30
@tringakrasniqi
Regenerate package
1b8191b 
Remove existing implementation

Co-authored-by: Tringa Krasniqi <[email protected]>
Change files
ce22d98
@theerebuss theerebuss requested review from a team June 15, 2021 15:05
@theerebuss theerebuss added this to the June Project Cycle Q2 2021 milestone Jun 15, 2021
@theerebuss theerebuss mentioned this pull request Jun 15, 2021
Closed
44 tasks
@Hotell

Hotell commented Jun 15, 2021 •
edited by theerebuss
Loading

Copy link
Copy Markdown
Contributor

pls make sure to run nx migration generator as well 🙌 yarn nx workspace-generator migrate-converged-pkg --name='@fluentui/react-text'

@fabricteam

fabricteam commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 883 855 5000
BaseButton mount 975 990 5000
Breadcrumb mount 2691 2695 1000
ButtonNext mount 550 520 5000
Checkbox mount 1696 1674 5000
CheckboxBase mount 1446 1493 5000
ChoiceGroup mount 5242 5301 5000
ComboBox mount 1051 1029 1000
CommandBar mount 10343 10717 1000
ContextualMenu mount 6435 6502 1000
DefaultButton mount 1183 1150 5000
DetailsRow mount 4017 4031 5000
DetailsRowFast mount 4050 3996 5000
DetailsRowNoStyles mount 3840 3725 5000
Dialog mount 2217 2270 1000
DocumentCardTitle mount 158 142 1000
Dropdown mount 3361 3451 5000
FocusTrapZone mount 2016 1943 5000
FocusZone mount 1970 1920 5000
IconButton mount 1869 1946 5000
Label mount 337 359 5000
Layer mount 1915 1886 5000
Link mount 511 494 5000
MakeStyles mount 1827 1879 50000
MenuButton mount 1588 1544 5000
MessageBar mount 2071 2070 5000
Nav mount 3575 3500 1000
OverflowSet mount 1072 1057 5000
Panel mount 2123 2095 1000
Persona mount 852 856 1000
Pivot mount 1454 1478 1000
PrimaryButton mount 1385 1367 5000
Rating mount 8217 8277 5000
SearchBox mount 1428 1473 5000
Shimmer mount 2779 2709 5000
Slider mount 2049 2032 5000
SpinButton mount 5242 5446 5000
Spinner mount 456 426 5000
SplitButton mount 3336 3318 5000
Stack mount 533 528 5000
StackWithIntrinsicChildren mount 1652 1687 5000
StackWithTextChildren mount 5028 4999 5000
SwatchColorPicker mount 10826 10925 5000
Tabs mount 1438 1463 1000
TagPicker mount 2581 2598 5000
TeachingBubble mount 12844 12502 5000
Text mount 467 469 5000
TextField mount 1521 1581 5000
ThemeProvider mount 1314 1275 5000
ThemeProvider virtual-rerender 735 645 5000
ThemeProviderNext mount 7107 7211 5000
Toggle mount 915 922 5000
buttonNative mount 110 123 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 203 180 1.13:1
AvatarMinimalPerf.default 231 209 1.11:1
FlexMinimalPerf.default 325 293 1.11:1
ChatMinimalPerf.default 720 662 1.09:1
TableMinimalPerf.default 474 436 1.09:1
FormMinimalPerf.default 495 457 1.08:1
GridMinimalPerf.default 365 337 1.08:1
ListWith60ListItems.default 762 706 1.08:1
CarouselMinimalPerf.default 527 492 1.07:1
DividerMinimalPerf.default 430 402 1.07:1
AlertMinimalPerf.default 335 315 1.06:1
CardMinimalPerf.default 630 594 1.06:1
RefMinimalPerf.default 251 237 1.06:1
TextAreaMinimalPerf.default 583 552 1.06:1
AnimationMinimalPerf.default 478 454 1.05:1
DropdownManyItemsPerf.default 795 758 1.05:1
LabelMinimalPerf.default 431 412 1.05:1
PortalMinimalPerf.default 184 175 1.05:1
RadioGroupMinimalPerf.default 526 500 1.05:1
SegmentMinimalPerf.default 409 391 1.05:1
DialogMinimalPerf.default 846 814 1.04:1
HeaderSlotsPerf.default 861 830 1.04:1
ReactionMinimalPerf.default 421 405 1.04:1
StatusMinimalPerf.default 802 768 1.04:1
IconMinimalPerf.default 735 705 1.04:1
DropdownMinimalPerf.default 3357 3254 1.03:1
MenuMinimalPerf.default 908 878 1.03:1
TableManyItemsPerf.default 2208 2153 1.03:1
TextMinimalPerf.default 395 384 1.03:1
ToolbarMinimalPerf.default 1040 1010 1.03:1
TreeWith60ListItems.default 197 191 1.03:1
ChatWithPopoverPerf.default 402 395 1.02:1
ItemLayoutMinimalPerf.default 1401 1369 1.02:1
PopupMinimalPerf.default 605 591 1.02:1
ChatDuplicateMessagesPerf.default 314 312 1.01:1
CheckboxMinimalPerf.default 2930 2906 1.01:1
EmbedMinimalPerf.default 4412 4384 1.01:1
MenuButtonMinimalPerf.default 1713 1700 1.01:1
ProviderMinimalPerf.default 1083 1071 1.01:1
SplitButtonMinimalPerf.default 4126 4101 1.01:1
ButtonMinimalPerf.default 203 202 1:1
HeaderMinimalPerf.default 395 396 1:1
ListMinimalPerf.default 549 547 1:1
LoaderMinimalPerf.default 756 755 1:1
CustomToolbarPrototype.default 4081 4091 1:1
TooltipMinimalPerf.default 1060 1063 1:1
VideoMinimalPerf.default 688 688 1:1
ButtonOverridesMissPerf.default 1785 1810 0.99:1
ListCommonPerf.default 693 699 0.99:1
ProviderMergeThemesPerf.default 1708 1717 0.99:1
InputMinimalPerf.default 1333 1361 0.98:1
LayoutMinimalPerf.default 417 426 0.98:1
SliderMinimalPerf.default 1639 1667 0.98:1
AttachmentSlotsPerf.default 1219 1263 0.97:1
ButtonSlotsPerf.default 599 620 0.97:1
SkeletonMinimalPerf.default 397 409 0.97:1
TreeMinimalPerf.default 860 887 0.97:1
BoxMinimalPerf.default 377 391 0.96:1
ImageMinimalPerf.default 409 426 0.96:1
RosterPerf.default 1258 1315 0.96:1
ListNestedPerf.default 592 649 0.91:1
DatepickerMinimalPerf.default 5722 6422 0.89:1
AccordionMinimalPerf.default 167 194 0.86:1

@theerebuss

theerebuss commented Jun 15, 2021

Copy link
Copy Markdown
Contributor Author

pls make sure to run nx migration generator as well 🙌 yarn nx workspace-generator migrate-converged-pkg --name='@fluentui/react-text'

Done, thanks for the reminder!

Hotell
Hotell reviewed Jun 15, 2021
View reviewed changes
Comment thread packages/react-text/package.json
@size-auditor

size-auditor Bot commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: eaa1b6508d34b44458f7b66507c4ae4c14c9f07c (build)

@Hotell Hotell mentioned this pull request Jun 16, 2021
Closed
32 tasks
@theerebuss theerebuss requested a review from a team as a code owner June 16, 2021 12:03
@theerebuss theerebuss requested a review from Hotell June 16, 2021 17:55
khmakoto
khmakoto approved these changes Jun 16, 2021
View reviewed changes

@khmakoto khmakoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread packages/react-examples/src/react-button/Playground.tsx Outdated
Hotell
Hotell reviewed Jun 17, 2021
View reviewed changes
Comment thread nx.json Outdated
@theerebuss theerebuss merged commit 9785ced into microsoft:master Jun 17, 2021
@theerebuss theerebuss deleted the text-scaffolding branch June 17, 2021 18:04
@Hotell Hotell mentioned this pull request Mar 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hotell Hotell Hotell approved these changes
@khmakoto khmakoto khmakoto approved these changes
+1 more reviewer
@ling1726 ling1726 ling1726 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@miroslavstastny miroslavstastny

Labels

Component: Text Fluent UI react-components (v9)

Projects

None yet

Milestone

June Project Cycle Q2 2021

Development

Successfully merging this pull request may close these issues.

6 participants

@theerebuss @Hotell @fabricteam @khmakoto @ling1726 @miroslavstastny