Skip to content

[Bug]: @types/[email protected] contains breaking change that fails tsc on fluentui/react (V8) #27425

Description

@Hotell

Library

React / v8 (@fluentui/react)

System Info

na

Are you reporting Accessibility issue?

None

Reproduction

https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=295858&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=254ee48e-1503-524f-f75e-e2c69d0380f5

  1. yarn lage build --to @fluentui/ts-minbar-test-react
  2. yarn workspace @fluentui/ts-minbar-test-react test

Bug Description

Actual Behavior

Observed yesterday (3rd of April in master pipeline ).

our TS minbar is a safeguard to prevent shipping non supported TS features to our users.

for react(v8) test suite we specify dependencies like for react types via @types/react@17, which during test run will install latest 17 type version.

  • version 17.0.55 worked as expected
  • version 17.0.56 introduced breaking change making tsc throw error

👀 Issue introduce by this PR DefinitelyTyped/DefinitelyTyped@3f5d206#diff-6df5e9a2eb9edb2dcf93fe75b95032e8870a94789157856c5544ece346026a0a

Diff:

image

image

image

version 17.0.56 did some content interface property re-shuffling which causes following tsc errors:

image

Expected Behavior

minor/patch versions of 3rd party types should not introduce breaking changes - this needs to be fixed on DefinitelyTyped repo.

Logs

No response

Requested priority

Blocking

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions