Skip to content

v9 shared form control styles: Input, Select, Combobox, Textarea #22231

Description

@smhigley

Ref: https://github.com/microsoft/fluentui/pull/21068/files#r829433773

We have a number of shared styles and shared style constants (e.g. padding, animation timing, etc.) across Input, Select, Combobox, and Textarea. It would make sense to share those styles somewhere centralized, but we'd need to figure out where.

Existing considerations:

  • Focus styles were added to react-tabster in Textarea: Adding implementation #22096. I think this is worth revisiting, since while it does centralize the shared focus style, it also bakes a lot of very theme-specific styles into react-tabster, even with the passed-in options.
  • We have both shared styles (e.g. the focus indicator) and also shared constants (the input padding, for instance)
  • Some of the shared constants are defined in the react-text package, but are not exported (see Select vNext styles #21068 (comment) for more context)

Metadata

Metadata

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions