Skip to content

Bug: infinite loop in a Modal #1624

Description

@maxilev

Bug Report

I found a bug in Modal.js which causing infinite loop here: https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/office-ui-fabric-react/src/components/Modal/Modal.tsx#L74

prevProps and prevState are not in correct order, the actual code should be:

public componentDidUpdate(prevProps: IModalProps, prevState: IDialogState) {

Metadata

Metadata

Assignees

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions