Skip to content

Button aria labels #1621

Description

@scriby

I noticed a bad bug in our codebase where we were setting aria-label on fabric Button elements instead of ariaLabel. There's no compiler error because aria-label is an intrinsic attribute.

The problem is that the aria-label isn't honored and gets dropped on the floor. Should we allow Button (and other applicable controls) to accept either aria-label or ariaLabel?

While looking into this I noticed something else a little bit strange which is that buttons which aren't explicitly labelled with an ariaLabel will be marked with something like aria-labelledby=123.

The first problem with that is there's no 123 element, and the 2nd is that 123 isn't even a valid element id.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions