Hotfix/portal memory leak (#26435)

arthurd-micro · web-flow · commit f64402777025 · 2023-01-23T08:06:52.000+01:00
* clean virtual parent reference

* changelog

* reuse setVirtual and remove cleanVirtualParent
diff --git a/change/@fluentui-react-portal-cc923a38-5b66-41a7-95fb-306fefd5e3f4.json b/change/@fluentui-react-portal-cc923a38-5b66-41a7-95fb-306fefd5e3f4.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "clean up parent reference to avoid memory leaks",
+  "packageName": "@fluentui/react-portal",
+  "email": "arthurd@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/react-components/react-portal/src/components/Portal/usePortal.ts b/packages/react-components/react-portal/src/components/Portal/usePortal.ts
@@ -26,6 +26,9 @@ export const usePortal_unstable = (props: PortalProps): PortalState => {
     if (state.virtualParentRootRef.current && state.mountNode) {
       setVirtualParent(state.mountNode, state.virtualParentRootRef.current);
     }
+    return () => {
+      if (state.mountNode) {setVirtualParent(state.mountNode, undefined);}
+    };
   }, [state.virtualParentRootRef, state.mountNode]);
 
   return state;

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,9 @@ export const usePortal_unstable = (props: PortalProps): PortalState => {`
`26`	`26`	`if (state.virtualParentRootRef.current && state.mountNode) {`
`27`	`27`	`setVirtualParent(state.mountNode, state.virtualParentRootRef.current);`
`28`	`28`	`}`
	`29`	`+ return () => {`
	`30`	`+ if (state.mountNode) {setVirtualParent(state.mountNode, undefined);}`
	`31`	`+ };`
`29`	`32`	`}, [state.virtualParentRootRef, state.mountNode]);`
`30`	`33`
`31`	`34`	`return state;`