Support meta history in bulk update#5370
Merged
LTA-Thinking merged 4 commits intomainfrom Feb 6, 2026
Merged
Conversation
LTA-Thinking
added
Enhancement
rajithaalurims
approved these changes
Feb 6, 2026
Contributor
rajithaalurims
left a comment
rajithaalurims
left a comment
There was a problem hiding this comment.
RB is going to add another E2E in a follow up PR
rbans96
reviewed
Feb 6, 2026
| [ServiceFilter(typeof(ValidateAsyncRequestFilterAttribute))] | ||
| [AuditEventType(AuditEventSubType.BulkUpdate)] | ||
| public async Task<IActionResult> BulkUpdate([FromBody] Parameters paramsResource, [FromQuery(Name = KnownQueryParameterNames.IsParallel)] bool? isParallel = null, [FromQuery(Name = KnownQueryParameterNames.MaxCount)] uint maxCount = 0) | ||
| public async Task<IActionResult> BulkUpdate([FromBody] Parameters paramsResource, [FromQuery(Name = KnownQueryParameterNames.IsParallel)] bool? isParallel = null, [FromQuery(Name = KnownQueryParameterNames.MaxCount)] uint maxCount = 0, [FromQuery(Name =KnownQueryParameterNames.MetaHistory)] bool metaHistory = true) |
rbans96
reviewed
Feb 6, 2026
| } | ||
|
|
||
| [SkippableFact] | ||
| public async Task GivenBulkUpdateWithMetaHistoryDisabled_WhenCompleted_ThenNoHistoricalVersionWasCreated() |
Contributor
There was a problem hiding this comment.
Should we add a test _meta-history=true to verify that history is created when _meta-history=true (default) to ensure the parameter works both ways.
rbans96
reviewed
Feb 6, 2026
| var substituteResults = new BulkUpdateResult(); | ||
| substituteResults.ResourcesUpdated["Patient"] = 3; | ||
| _updater.UpdateMultipleAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<bool>(), 0, Arg.Any<bool>(), Arg.Any<IReadOnlyList<Tuple<string, string>>>(), Arg.Any<BundleResourceContext>(), Arg.Any<CancellationToken>()) | ||
| _updater.UpdateMultipleAsync(Arg.Any<string>(), Arg.Any<string>(), Arg.Any<bool>(), 0, Arg.Any<bool>(), Arg.Any<IReadOnlyList<Tuple<string, string>>>(), Arg.Any<BundleResourceContext>(), Arg.Any<bool>(), Arg.Any<CancellationToken>()) |
Contributor
There was a problem hiding this comment.
Can we add/update a unit test to verify metaHistory(true) is passed passed as default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows for support of the
_meta-historyparameter in$bulk-updaterequests.Related issues
Addresses User Story 180713
Testing
New E2E test and manual testing
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)