Skip to content

Fix terminology consistency and variable naming in E2E tests#5344

Closed
Copilot wants to merge 5 commits intomainfrom
copilot/sub-pr-5341
Closed

Fix terminology consistency and variable naming in E2E tests#5344
Copilot wants to merge 5 commits intomainfrom
copilot/sub-pr-5341

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026 •
edited
Loading

Description

Addressed code review feedback for spelling and best practices in InstantiatesCapabilityProviderTests.cs:

  • Terminology consistency: Standardized "US Core 6" format in user-facing messages (was inconsistent between "USCore 6" and "US Core 6")
  • Variable naming: Renamed instantiates → instantiatesUrls for clarity (line 73)

Related issues

Addresses [issue #95785].

User Story 95785: Instantiate field and export endpoint is added under Capability statement

Testing

Syntax validated. Full test execution handled by existing CI pipeline.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Jan 23, 2026
Merged
1 task
Copy link
Contributor Author

Copilot AI commented Jan 23, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • microsofthealthoss.pkgs.visualstudio.com
    • Triggering command: /usr/bin/dotnet dotnet build test/Microsoft.Health.Fhir.R4.Tests.E2E/Microsoft.Health.Fhir.R4.Tests.E2E.csproj --no-restore (dns block)
    • Triggering command: /usr/bin/dotnet dotnet restore test/Microsoft.Health.Fhir.R4.Tests.E2E/Microsoft.Health.Fhir.R4.Tests.E2E.csproj (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add E2E tests for InstantiatesCapabilityProvider Fix terminology consistency and variable naming in E2E tests Jan 23, 2026
Copilot AI requested a review from v-isyamauchi-gh January 23, 2026 17:36
Base automatically changed from personal/v-isyamauchi/add-instantiates-e2e to main January 23, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-isyamauchi-gh v-isyamauchi-gh Awaiting requested review from v-isyamauchi-gh

Assignees

Copilot code review Copilot

@v-isyamauchi-gh v-isyamauchi-gh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-isyamauchi-gh