Fix SQL UNION column count mismatch in include/revinclude queries#5340
Merged
mikaelweave merged 1 commit intomainfrom Jan 23, 2026
Merged
Conversation
When using _include and _revinclude together in FHIR search queries, the SQL generator was producing UNION statements with mismatched column counts. Include queries projected 3 columns (T1, Sid1, IsMatch) while other branches projected 4 columns (T1, Sid1, IsMatch, IsPartial). The fix ensures IsPartial is always projected in HandleTableKindInclude() regardless of IsIncludesOperation flag. Added E2E regression test to verify the fix.
rbans96
approved these changes
Jan 21, 2026
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using _include and _revinclude together in FHIR search queries, the SQL generator was producing UNION statements with mismatched column counts. Include queries projected 3 columns (T1, Sid1, IsMatch) while other branches projected 4 columns (T1, Sid1, IsMatch, IsPartial).
The fix ensures IsPartial is always projected in HandleTableKindInclude() regardless of IsIncludesOperation flag.
Added E2E regression test to verify the fix.
Related issues
AB#181200
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)