Skip to content

Fix delete issue context#5336

Merged
LTA-Thinking merged 2 commits intomainfrom
personal/rojo/bulk-delete-include-fix
Jan 23, 2026
Merged

Fix delete issue context#5336
LTA-Thinking merged 2 commits intomainfrom
personal/rojo/bulk-delete-include-fix

Conversation

@LTA-Thinking
Copy link
Contributor

Description

Fix bug where a page of matches after a page with an include related link will error.
The problem was the issue context of the previous page, which had the "included results truncated" warning, wasn't being cleared before the next search was done. This caused the next page to also look like it had included results, when it didn't.

Related issues

Addresses Bug 180915

Testing

Manual

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@LTA-Thinking LTA-Thinking added this to the FY26\Q3\2Wk\2Wk15 milestone Jan 15, 2026
@LTA-Thinking LTA-Thinking requested a review from a team as a code owner January 15, 2026 18:45
@LTA-Thinking LTA-Thinking added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Jan 15, 2026
@rbans96
Copy link
Contributor

rbans96 commented Jan 15, 2026

Thanks for the fix. Do you think if its possible to add a test for this scenario?

@LTA-Thinking
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LTA-Thinking
Copy link
Contributor Author

Thanks for the fix. Do you think if its possible to add a test for this scenario?

I don't think a test would be worth it as it would involve loading at least 2000 resources. The run time isn't worth the coverage in my opinion.

@LTA-Thinking
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LTA-Thinking
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LTA-Thinking
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jestradaMS jestradaMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestion to add XML doc comment explaining what ict is and when method returns true

@LTA-Thinking LTA-Thinking merged commit 94ea23d into main Jan 23, 2026
62 of 65 checks passed
@LTA-Thinking LTA-Thinking deleted the personal/rojo/bulk-delete-include-fix branch January 23, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. No-ADR ADR not needed No-PaaS-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants