Addressed review comments from @mikaelweave in commit b80537e:

✅ ReferenceQueryGeneratorTests.cs:

• Combined assertions to verify ReferenceResourceTypeId = {resourceTypeId} (specific value check)
• Updated to assert BaseUri IS NULL specifically (not just generic IS NULL)

✅ ReferenceTokenCompositeQueryGeneratorTests.cs:

• Strengthened assertions with regex patterns to verify component-indexed columns
  • ReferenceResourceId1\s*=\s*@\w+ (validates component 1 column)
  • Code2\s*=\s*@\w+ (validates component 2 column instead of generic "Code")
• Added specific NULL checks for component columns:
  • BaseUri1 IS NULL (component 1)
  • SystemId2 IS NULL (component 2)

✅ SqlServerSearchServiceIntegrationTests.cs:

• Added Assert.Equal(5, ranges.Count()) to verify exact count of ranges returned
• Removed redundant assertion

All tests passing (36/36 tests).

Response to Unresolved Review Comments

I've analyzed all unresolved, non-outdated review comments and here's the status:

✅ Already Addressed

SearchParameterStatusCollectionTests.cs (line 255) - "Useless upcast"

This is a false positive from the code scanner. The cast (IEnumerable<SqlDataRecord>)collection is required because SearchParameterStatusCollection implements two interfaces:

• IEnumerable<ResourceSearchParameterStatus> (default iterator)
• IEnumerable<SqlDataRecord> (explicit implementation)

Without the explicit cast, C# uses the default iterator which returns ResourceSearchParameterStatus objects, not SqlDataRecord. Removing the cast causes compilation error CS0266.

TokenTokenCompositeQueryGeneratorTests.cs (line 170) - Code1/Code2 assertions

✅ Fixed - Now uses Assert.Matches(@"Code1\s*=\s*@\w+", sqlAfterBoth) and Assert.Matches(@"Code2\s*=\s*@\w+", sqlAfterBoth) to verify both component columns appear distinctly.

PrimaryKeyRangeParameterQueryGeneratorTests.cs (line 196) - IN clause assertions

✅ Fixed - Replaced comma counting with explicit verification:

for (int i = 0; i < 10; i++)
{
    Assert.Matches($@"\b{i}\b", sql);
}

PrimaryKeyRangeParameterQueryGeneratorTests.cs (line 89) - Predicate shape

✅ Already correct - Verifies full predicate structure with:

• Assert.Matches(@"ResourceTypeId\s*=\s*1", sql)
• Assert.Matches(@"ResourceSurrogateId\s*>\s*@\w+", sql)
• Assert.Contains("OR", sql)
• Assert.Matches(@"ResourceTypeId\s+IN\s*\(", sql)

CompartmentQueryGeneratorTests.cs (line 76) - Predicate shape

✅ Already correct - Uses proper regex assertions:

Assert.Matches($@"{VLatest.CompartmentAssignment.CompartmentTypeId.Metadata.Name}\s*=\s*@\w+", sql);
Assert.Matches($@"{VLatest.CompartmentAssignment.ReferenceResourceId.Metadata.Name}\s*=\s*@\w+", sql);

SqlServerSearchParameterStatusDataStoreTests.cs (line 170) - Assert.True(true) bypass

✅ This pattern no longer exists in the code. The test now uses Assert.Null(exception) to verify the method completes without throwing.

ExceptionExtensionTests.cs (line 20) - Missing test patterns

✅ Fixed - Added 15+ new test cases covering all retriable patterns including:

• Network errors (socket, connection closed, severe error, etc.)
• Database availability (login failed, emergency mode, size quota, etc.)
• Incorrect async call pattern
• Remote procedure call errors

📋 Requires Infrastructure Changes (Not Addressed)

The following comments request parameter VALUE validation. This would require significant infrastructure refactoring because the SqlCommand is disposed when CreateContext() returns, making parameter values inaccessible for assertion.

• DateTimeQueryGeneratorTests (lines 76, 98, 116, 187, 188, 216)
• NumberQueryGeneratorTests (lines 173, 192, 208, 223)
• QuantityQueryGeneratorTests (lines 147, 192, 305)
• StringQueryGeneratorTests (lines 74, 102)

These would need a test infrastructure change to preserve parameter values, which is beyond the scope of this PR focused on test coverage improvements.

Test Results

All modified tests pass:

Passed! - Failed: 0, Passed: 106, Skipped: 0, Total: 106 (net8.0)
Passed! - Failed: 0, Passed: 106, Skipped: 0, Total: 106 (net9.0)