Handle all BYOK errors from Cosmos DB#1014
Merged
Conversation
namadabu
reviewed
May 11, 2020
src/Microsoft.Health.Fhir.Core/Exceptions/CmkAadClientCredentialsGrantFailureException.cs
Outdated
Show resolved
Hide resolved
namadabu
reviewed
May 11, 2020
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/CosmosResponseProcessor.cs
Outdated
Show resolved
Hide resolved
namadabu
reviewed
May 11, 2020
src/Microsoft.Health.Fhir.CosmosDb.UnitTests/Features/Storage/CosmosResponseProcessorTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.CosmosDb/Features/Storage/CosmosDbSubStatusValues.cs
Outdated
Show resolved
Hide resolved
shmartel
commented
May 16, 2020
shmartel
commented
May 16, 2020
src/Microsoft.Health.Fhir.CosmosDb/Features/Storage/CosmosResponseProcessor.cs
Outdated
Show resolved
Hide resolved
namadabu
reviewed
May 20, 2020
src/Microsoft.Health.CosmosDb/Features/Storage/KnownCosmosDbCmkSubStatusValue.cs
Outdated
Show resolved
Hide resolved
namadabu
reviewed
May 20, 2020
...ft.Health.Fhir.Shared.Api.UnitTests/Features/Filters/OperationOutcomeExceptionFilterTests.cs
Outdated
Show resolved
Hide resolved
…CosmosDb" This reverts commit 0122a1e.
src/Microsoft.Health.Fhir.Core/Microsoft.Health.Fhir.Core.csproj
Outdated
Show resolved
Hide resolved
…e a couple PR comments
…/github.com/Microsoft/fhir-server into personal/shmartel/byok-all-cosmos-db-errors
…essage from Core and into CosmosDb. This removes any Cosmos-related knownledge from Core - Cosmos DB has published documentation on BYOK substatus codes: https://docs.microsoft.com/en-us/rest/api/cosmos-db/http-status-codes-for-cosmosdb. Updating Resources to better aligned with the Cosmos wording.
shmartel
commented
Jun 22, 2020
namadabu
reviewed
Jun 22, 2020
src/Microsoft.Health.Fhir.Core/Exceptions/CustomerManagedKeyException.cs
Show resolved
Hide resolved
namadabu
approved these changes
Jun 22, 2020
brendankowitz
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cosmos DB has provide sub status codes and descriptions for all the possible BYOK errors returned from their service.
Related issues
Addresses #73777
Testing
Added unit test coverage