Merged
Conversation
7ad6615 to
ab5f722
Compare
limorl
pushed a commit
to limorl/fhir-server
that referenced
this pull request
Sep 30, 2020
limorl
pushed a commit
that referenced
this pull request
Oct 23, 2020
* All include test pass But public async Task GivenARevIncludeSearchExpression_WhenSearchedWithPost_ThenCorrectBundleShouldBeReturned() due to count summary * fix tests to exclude exclude some of the IncludeSearchTests in R4 and R5 * Remove recursive :iterate implementation * add resources.designer.cs * fox PR comments - round #1 * remove redundant assignments * Fix IncludeExpression.ToString() to potemtially remove redundant spaces * avoid computing AllIterateModifiers each time, instead make a static readonly * fix IncludeReqriter to reuse a static TableExpressionComparer and OrderBy ascending instead of descending * Resources.Designer: un-delete summary comment * Fix issue with _include:iterate and _revinclude_iterate parameters not showing up in the bundle url * Remove ContainsInclude from IncludeRewriter and use TableExpressionKind.Include in the Comparer * updated IncludeRewriterTests * Update TableExpressionComparer to avoid allocating new lists * fix type in TableExpressionComparer * Fix ExpressionParser allocation heavy code for initializing reference types * Remove Top(MaxItemCount) for include ieterate CTEs * validate indirect dependencies are handled in comparer * use topological sort to order the include parameters * sync master (update resources) * fix merge issue in resources.resx * clean topological sort + return InvalidSearchOperation for cyclic include iterate queries
1 task
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.