This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Experimental Features: Check for feature presence, dynamically (Quiet Mode) #3545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsidewhite
requested review from
EricJohnson327,
btueffers,
krschau and
nieubank
krschau
reviewed
Aug 5, 2024
settings/DevHome.Settings/ViewModels/ExperimentalFeaturesViewModel.cs
Outdated
Show resolved
Hide resolved
settings/DevHome.Settings/ViewModels/ExperimentalFeaturesViewModel.cs
Outdated
Show resolved
Hide resolved
krschau
approved these changes
Aug 5, 2024
| public ExperimentalFeaturesViewModel(IExperimentationService experimentationService) | ||
| { | ||
| ExperimentalFeatures = experimentationService!.ExperimentalFeatures.Where(x => x.IsVisible).OrderBy(x => x.Id).ToList(); | ||
| ExperimentalFeatures = experimentationService!.ExperimentalFeatures.Where(x => x.IsVisible && (!x.NeedsFeaturePresenceCheck || IsFeaturePresent(x))).OrderBy(x => x.Id).ToList(); |
Contributor
There was a problem hiding this comment.
Nit: Comment might help here
vineeththomasalex
approved these changes
Aug 6, 2024
settings/DevHome.Settings/ViewModels/ExperimentalFeaturesViewModel.cs
Outdated
Show resolved
Hide resolved
dkbennett
suggested changes
Aug 6, 2024
jsidewhite
deleted the
user/jwhites/quiet__isfeaturepresentcheck_dynamic
branch
This was referenced Aug 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Check for feature presence dynamically for experimental features that request it.
This enables hiding features on OSes that don't have support.
Validation steps performed
Manually ran it on an OS that doesn't support the feature, and it doesn't render in Settings.
PR checklist