This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Mapping of extensions to repository paths in DevHome core #3230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssparach
commented
Jun 13, 2024
ssparach
commented
Jun 13, 2024
extensionsdk/Microsoft.Windows.DevHome.SDK/Microsoft.Windows.DevHome.SDK.idl
Outdated
Show resolved
Hide resolved
ssparach
requested review from
DefaultRyan,
jamespik,
manodasanW and
vineeththomasalex
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.Customization/Views/FileExplorerPage.xaml.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Jun 19, 2024
tools/Customization/DevHome.FileExplorerSourceControlIntegration/Services/RepositoryTracking.cs
Outdated
Show resolved
Hide resolved
ssparach
force-pushed
the
user/ssparach/extensionMapping
branch
from
802f3d5 to
408ba52
Compare
…changes, SDK changes, get extension information to use for mapping
…git implementation
ssparach
force-pushed
the
user/ssparach/extensionMapping
branch
from
408ba52 to
c3743ec
Compare
DefaultRyan
suggested changes
Jul 1, 2024
tools/Customization/DevHome.Customization/Models/SourceControlIntegration.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.Customization/ViewModels/FileExplorerViewModel.cs
Outdated
Show resolved
Hide resolved
tools/Customization/DevHome.FileExplorerSourceControlIntegration/SourceControlProvider.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
reviewed
Jul 8, 2024
tools/Customization/DevHome.FileExplorerSourceControlIntegration/SourceControlProvider.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
reviewed
Jul 8, 2024
tools/Customization/DevHome.Customization/Models/SourceControlIntegration.cs
Outdated
Show resolved
Hide resolved
DefaultRyan
suggested changes
Jul 8, 2024
Member
DefaultRyan
left a comment
DefaultRyan
left a comment
There was a problem hiding this comment.
There are still some open comments from Darren as well.
DefaultRyan
approved these changes
Jul 10, 2024
dhoehna
reviewed
Jul 10, 2024
| { | ||
| var lastTimeModified = System.IO.File.GetLastWriteTime(Path.Combine(RepoStoreOptions.RepoStoreFolderPath, RepoStoreOptions.RepoStoreFileName)); | ||
| log.Information("Last Time Modified: {0}", lastTimeModified); | ||
| if (DateTime.Compare(LastRestore, lastTimeModified) < 0) |
Contributor
There was a problem hiding this comment.
Consider changing both LastRestore and lastTimemodified to UTCtime for comparison. This can fail during daylight savings time.
A specific edge case, but can still happen.
dhoehna
approved these changes
Jul 10, 2024
ssparach
added a commit
that referenced
this pull request
Jul 31, 2024
* declare appextension for git, find all source control extensions, UI changes, SDK changes, get extension information to use for mapping * changes to map extension to registered root paths, add validation to git implementation * changes after testing * use serilog in validation code * reorder using * use published SDK version * address PR feedback * address PR feedback * address PR feedback * Minor cleanup of RepositoryTracking.cs --------- Co-authored-by: Ryan Shepherd <[email protected]>
ssparach
added a commit
that referenced
this pull request
Aug 1, 2024
* declare appextension for git, find all source control extensions, UI changes, SDK changes, get extension information to use for mapping * changes to map extension to registered root paths, add validation to git implementation * changes after testing * use serilog in validation code * reorder using * use published SDK version * address PR feedback * address PR feedback * address PR feedback * Minor cleanup of RepositoryTracking.cs --------- Co-authored-by: Ryan Shepherd <[email protected]>
ssparach
added a commit
that referenced
this pull request
Aug 2, 2024
* reset branch to 548d868 * Revert "reset branch to 548d868" This reverts commit f30055f. * Merged PR 10695071: Move to feature branch in preparation for GitHub **Summary of the pull request** This PR contains implementation changes for the File Explorer Source Control Integration experimental feature. This feature will allow File Explorer to obtain property information from source control technologies for display (image attached below): **Detailed description of the pull request / Additional comments** This PR contains the following changes: - Reference official Dev Home SDK version (that defines APIs for File Explorer Source Control Integration) - Declare FileExplorerSourceControlIntegration as an experimental feature - The FileExplorerSourceControlIntegration project which creates a COM Server used to communicate information with File Explorer - The FileExplorerGitIntegration project which allows Dev Home to come with an inbox extension that understands git - Basic Unit Tests **Validation steps performed** SDK and MSIX local builds Tested Git Integration File Explorer behavior inside VM Related work items: #48431506 * Mapping of extensions to repository paths in DevHome core (#3230) * declare appextension for git, find all source control extensions, UI changes, SDK changes, get extension information to use for mapping * changes to map extension to registered root paths, add validation to git implementation * changes after testing * use serilog in validation code * reorder using * use published SDK version * address PR feedback * address PR feedback * address PR feedback * Minor cleanup of RepositoryTracking.cs --------- Co-authored-by: Ryan Shepherd <[email protected]> * save state * save state * save state * save state * save state * implement button actions * changes * address PR feedback * address PR feedback * rebased user branch, made fixes, validated functionality on VM * cleanup UI changes, tested on VM * fix proj references to match dev home feed and unblock PR pipeline --------- Co-authored-by: Ryan Shepherd <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR contains code changes for a root path to be validated in association with a given source control provider on Dev Home to be mapped accordingly. The CLSID for the extension point is used to map to the persisted registered repository root paths. The CLSID is chosen as it is compatible with both packaged and unpackaged extensions, this value is not recycled by unrelated applications and is explicitly defined.
**Note: The UI in this PR is subject to change **
References and relevant issues
Detailed description of the pull request / Additional comments
Note: This currently finds and binds the extension name to the UI. Per design, this is subject to change i.e. Dev Home may become responsible for recognizing the right extension and automatically mapping.
Validation steps performed
Build release msix
Run added unit tests
Test functionality of msix package on a VM
PR checklist