This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Improving the narrator with DevHome #2986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
approved these changes
May 22, 2024
Collaborator
krschau
left a comment
krschau
left a comment
There was a problem hiding this comment.
Maybe include a comment about how setting the accessible name in the resw file didn't work because DataTemplate?
Contributor
Author
Added. |
guimafelipe
approved these changes
May 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
In some places, the narrator was not saying the correct thing in 3 specific cases
...on an environment card. Narrator now says "More Options"References and relevant issues
https://task.ms/50453529
https://task.ms/50453302
https://task.ms/50453587
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran through the items.
PR checklist