This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Add measure telemetry for environment operations #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanismohammed
approved these changes
Apr 17, 2024
huzaifa-d
approved these changes
Apr 17, 2024
…ub.com/microsoft/devhome into user/bbonaby/add-environment-mearsures
huzaifa-d
reviewed
Apr 17, 2024
| private Action? DevHomeAction { get; } | ||
|
|
||
| public OperationsViewModel(string name, string icon, Func<string, Task<ComputeSystemOperationResult>> command) | ||
| public OperationsViewModel(string name, string icon, Func<string, Task<ComputeSystemOperationResult>> command, ComputeSystemOperations computeSystemOperation) |
Contributor
There was a problem hiding this comment.
Could have combined this and the other constructor with a parameter default value.
huzaifa-d
reviewed
Apr 17, 2024
| return (_stringResource.GetLocalized(StringResourceKey.ConfigurationUnitSummaryFull, unit.Intent, unit.Type, packageId, unitDescription), packageName); | ||
| } | ||
|
|
||
| private void LogCompletionTelemetry(TaskFinishedState taskFinishedState) |
Contributor
There was a problem hiding this comment.
Could directly send the EnvironmentsTelemetryStatus. And using this function at line 382 would be better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds the necessary telemetry events to get the success/failure of the following environment operations:
Startcompute system operation,ShutDowncompute system operation,Terminatecompute system operation,Deletecompute system operation,Savecompute system operation,Pausecompute system operation,Resumecompute system operation,Restartcompute system operation,CreateSnapshotcompute system operation,ApplyConfigurationto compute system operation.PinToStartMenuto compute system operation.PinToTaskBarto compute system operation.A telemetry event called
EnvironmentOperationUserEventwas created with theProductAndServiceUsagetag as all of these operations are a result of a user interaction.Two new classes called
ComputeSystemOperationStartedDataandComputeSystemOperationCompletedDatawere created to allow theOperationsViewModelto communicate the start and completion of the operations with theComputeSystemViewModelclass.Related Issue: #2565
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist