This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Making Banner's Close button icon text AccessibilityView raw #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimafelipe
requested review from
AmelBawa-msft,
EricJohnson327,
dhoehna,
dkbennett and
krschau
dhoehna
approved these changes
Apr 9, 2024
krschau
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
When Scan mode is activated, the narrator can focus the icon inside the close button's content. This PR fixes this issue.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/45042479
Detailed description of the pull request / Additional comments
With scan mode on, the narrator try to focus on every text, including the icon inside the banner's close button. Changing the accessibility view to
Rawremoves it from the list of controls observable by the narrator. Then, only the entire button can be focused.Validation steps performed
PR checklist