Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@guimafelipe
Copy link
Contributor

@guimafelipe guimafelipe commented Apr 4, 2024

Summary of the pull request

One of the last changes on SettingsCards control behaviour made it to use the Content of a Button as accessible name whenever its content is a Button, as seen here. This is making the cards on the extension library not having a meaningful accessible name, and making the narrator say nothing as the name of the group when the button is focused.

To fix this, we manually set the accessible name of the SettingCards of the not installed extensions and we put the button inside a StackPanel on the Expander, so it not use the button's content as accessible name.

References and relevant issues

https://dev.azure.com/microsoft/OS/_workitems/edit/49362208
https://dev.azure.com/microsoft/OS/_workitems/edit/49362247
https://dev.azure.com/microsoft/OS/_workitems/edit/49656514
https://dev.azure.com/microsoft/OS/_workitems/edit/49656599

Detailed description of the pull request / Additional comments

As the code on the above link shows, the SettingsCard behaviour is: if the Content of the card is a button, use the button's content as accessible name. This makes all our card that have buttons on the extensions library page to have the accesible name as just the button's text, which is not meaningful on most of the cases and is not desirable on buttons where the content is an icon, as it can't even be narrated.

As this behaviour only happens when the content base class is Button or TextBlock, putting it inside a StackPanel mitigates this with the cost of having a additional group nested.

Validation steps performed

PR checklist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility fixes for 0.13 milestone

4 participants