This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Updating community toolkit to prevent layout cycle. #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoehna
requested review from
a team,
AmelBawa-msft,
EricJohnson327,
SohamDas2021,
bbonaby,
brialmsft,
dkbennett,
hart-wilson,
huzaifa-d,
jaholme,
jsidewhite,
krschau,
manodasanW,
nieubank,
sshilov7,
ssparach and
vineeththomasalex
bbonaby
reviewed
Apr 4, 2024
bbonaby
reviewed
Apr 4, 2024
krschau
reviewed
Apr 4, 2024
...sses/DevHome.QuietBackgroundProcesses.Server/DevHome.QuietBackgroundProcesses.Server.vcxproj
Outdated
Show resolved
Hide resolved
3 tasks
krschau
reviewed
Apr 4, 2024
HyperVExtension/test/DevSetupEngine.Test/DevSetupEngine.Test.csproj
Outdated
Show resolved
Hide resolved
tools/Environments/DevHome.Environments/DevHome.Environments.csproj
Outdated
Show resolved
Hide resolved
…sproj Co-authored-by: Kristen Schau <[email protected]>
Co-authored-by: Kristen Schau <[email protected]>
* comments * typo
krschau
approved these changes
Apr 5, 2024
bbonaby
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The EqualPanel in the Community Toolkit gets into a layout cycle when using windows app sdk 1.5
A fix is in the
-rcversion of the community toolkit. This PR upgrades the nuget packages to the-rcversion.References and relevant issues
Detailed description of the pull request / Additional comments
The target framework did have to change to 22621
Validation steps performed
Opened up DevHome with
4K at 150%, 125%, and 100%.
1920x1200 at 100%, 125%, and 150%.
No issues.
PR checklist