This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Provide API for registering nested pages #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
force-pushed
the
user/krschau/sub-pages
branch
from
c5c74f5 to
5351615
Compare
krschau
changed the title
3 tasks
krschau
force-pushed
the
user/krschau/sub-pages
branch
from
5351615 to
68bd0ef
Compare
krschau
force-pushed
the
user/krschau/sub-pages
branch
from
68bd0ef to
1ae2610
Compare
krschau
requested review from
AmelBawa-msft,
EricJohnson327,
bbonaby,
dkbennett,
guimafelipe and
vineeththomasalex
nieubank
reviewed
Mar 12, 2024
| * Dev Home widgets use the [Adaptive Card schema](https://adaptivecards.io/explorer/) version 1.5, which is the most recent schema supported by the WinUI 3 Adaptive Card renderer. | ||
| * There are [HostConfig](https://learn.microsoft.com/adaptive-cards/sdk/rendering-cards/uwp/host-config) files that define common styles (e.g., font family, font sizes, default spacing) and behaviors (e.g., max number of actions) for all the widgets. There is one for [light mode](../tools/Dashboard/DevHome.Dashboard/Assets/HostConfigLight.json) and one for [dark mode](../tools/Dashboard/DevHome.Dashboard/Assets/HostConfigDark.json). | ||
| * Dev Home supports a custom AdaptiveElement type called [`LabelGroup`](../common/Renderers/LabelGroup.cs). This allows a card author to render a set of labels, each with a specified background color. For an example of how to use this type, please see the [GitHub Issues widget](https://github.com/microsoft/devhomegithubextension/blob/main/src/GitHubExtension/Widgets/Templates/GitHubIssuesTemplate.json). | ||
| [Dashboard](./tools/Dashboard.md) |
Contributor
There was a problem hiding this comment.
Would it make sense to keep the tool-specific documentation in the tool's project folder itself? I found this helpful with the Customization tool bring up because the md file will show up in Visual Studio to make it easier to reference, then we could just keep a link to those here.
Collaborator
Author
There was a problem hiding this comment.
Keeping here for now, but might move things later. Still have some doc work upcoming.
dhoehna
reviewed
Mar 15, 2024
| { | ||
| Type GetPageType(string key); | ||
|
|
||
| public void Configure<T_VM, T_V>() |
Collaborator
Author
There was a problem hiding this comment.
I think it's like Type_ViewModel and Type_View. I used the existing function definition and just moved it.
dhoehna
approved these changes
Mar 15, 2024
nieubank
added a commit
that referenced
this pull request
Mar 18, 2024
- Update to incorporate #2356 for PageService sub-page registration - Update nuget package based on conflicts with newly added C++ projects that require packages.config - Remove breadcrumb until we figure out if there's going to be a common way to do this without duplicating so much code. The impact here is minimal since Customization doesn't have a ton of sub-pages (yet) - Mark SettingsChanged telemetry event to be a measure, I'm guessing this doesn't need to be Critical?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
As more tools and extensions are created, the list of pages to configure in App.xaml.cs could grow quite long. Instead, allow tools to create extension methods for the IPageService, similar to what we do in ServiceExtensions today. This keeps clutter out of the configuration list, and allows tools to stay more contained (internal classes, etc).
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist