Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@krschau
Copy link
Collaborator

@krschau krschau commented Mar 5, 2024

Summary of the pull request

Two bugs are fixed:

  • Due to a bug in AdaptiveCards, Positive and Destructive buttons are rendered with incorrect styling. It seems to be Windows 10 styling with square corners. Override the styling of Positive buttons to be Xaml's accent buttons, and make destructive buttons normal for now. We may choose an accessible foreground color in the future to match default behavior, which is to make the foreground color the "attention" color from the AC's HostConfig
  • Choose an accessible color for "attention" text as it is used today.

image

References and relevant issues

48295223, 48295257

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau krschau merged commit 6267af6 into main Mar 6, 2024
@krschau krschau deleted the user/krschau/accessible-colors branch March 6, 2024 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accessibility fixes for 0.12 milestone Possible contrast issue with active and disabled "Positive" widget buttons

4 participants