Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@licon4812
Copy link
Contributor

@licon4812 licon4812 commented Jan 30, 2024

Summary of the pull request

Adds the tool Apps & Packages which will allow for the management of packages that have been installed via winget and or the msstore

References and relevant issues

#1984

Detailed description of the pull request / Additional comments

Adds the tool Apps & Packages which will allow for the management of packages that have been installed via winget and or the msstore. Going to follow a similar design to what was mocked in #1984 with the addition of being able to remove packages as well

image

Validation steps performed

PR checklist

  • Created Apps & Packages Tool
  • Added new tool to shell
  • Created basic UI with AutoSuggestBox and data grid

@licon4812
Copy link
Contributor Author

This is nowhere near ready yet. I have only created the draft so that people know that I have started to work on it

@krschau krschau changed the base branch from main to feature/appspackages January 30, 2024 22:57
@krschau
Copy link
Collaborator

krschau commented Jan 30, 2024

Hi @licon4812! We're so excited you've started to work on this! For features this big, we like to work in a feature branch, so that we can have smaller, more reviewable PRs into that branch, then once it's all finished bring the whole thing into main. I've opened feature/appspackages and retargeted your PR into that branch. I see you've opened this as a draft, but I think it's actually a good first PR into the feature branch as-is.

Our PMs and designers are still putting the finishing touches on the specs for this feature but we do hope to have them published as drafts soon and finalized in the coming month. There should be enough in the current example images to continue working for now, but I want to be upfront that things could still change. We appreciate your patience!

@licon4812
Copy link
Contributor Author

@krschau Thank you for the comment. How about I do a basic mock up of the UI and some logic to get installed packages. Once I do that at a crude level I will mark this PR as ready to be merged

Hi @licon4812! We're so excited you've started to work on this! For features this big, we like to work in a feature branch, so that we can have smaller, more reviewable PRs into that branch, then once it's all finished bring the whole thing into main. I've opened feature/appspackages and retargeted your PR into that branch. I see you've opened this as a draft, but I think it's actually a good first PR into the feature branch as-is.

Our PMs and designers are still putting the finishing touches on the specs for this feature but we do hope to have them published as drafts soon and finalized in the coming month. There should be enough in the current example images to continue working for now, but I want to be upfront that things could still change. We appreciate your patience!

@licon4812 licon4812 marked this pull request as ready for review January 30, 2024 23:35
@licon4812 licon4812 changed the title Apps & Packages Creation of tool Apps & Packages with very basic WIP UI Jan 30, 2024
@licon4812
Copy link
Contributor Author

licon4812 commented Jan 30, 2024

This is what I have so far. It is very crude and needs more work. Let me know if it isn't adequate for a first PR

image

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small things:

@licon4812 licon4812 requested a review from krschau February 6, 2024 03:49
@krschau krschau merged commit 5329dd3 into microsoft:feature/appspackages Feb 6, 2024
@licon4812 licon4812 deleted the apps-packages branch February 6, 2024 21:32
@licon4812 licon4812 restored the apps-packages branch February 6, 2024 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apps & Packages - Feature Exploration!

3 participants