Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Conversation

@EricJohnson327
Copy link
Contributor

Summary of the pull request

There are two parts to this change:

  1. Add
true UseRidGraph is for buildtime while RuntimeHostConfigurationOption is for runtime. Both of these are needed.
  1. Switch runtime identifiers back to "win10" versions. The above RidGraph workaround doesn't mean "work with packages still using old win10 runtime identifiers". It actually means "use the old runtime identifier system instead of the new one".

After all dependencies have moved to the new .NET 8 runtime identifiers, we can remove the workarounds (#1) and change back to the new "win" runtime identifiers (#2)

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@manodasanW manodasanW self-requested a review January 19, 2024 00:24
@EricJohnson327 EricJohnson327 merged commit da44328 into main Jan 19, 2024
@EricJohnson327 EricJohnson327 deleted the user/ejohn/RidGraphFix branch January 19, 2024 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants