File Activation changes #1485
File Activation changes #1485
Conversation
|
@guimafelipe - as discussed there is a bug where the flow doesn't work for an invalid .dsc file |
…n the setup flow should a .winget file activation occur
|
Fixed bug for invalid .dsc file |
…n. Need to wait for the shell service to finish running on launch before handling file activation
|
@joadoumie I noticed this has still been in draft for about 2 weeks now. Do you still need a review on this or are you still working on it? |
|
@bbonaby I was OOF for a while... definitely do want to get this thing reviewed and make the necessary changes to get it merged in. |
|
Following up on this. @denelon for visibility |
joadoumie
requested review from
bbonaby and
dkbennett
and removed request for
dkbennett
|
Ping @joadoumie Is this still wanted? Converting to draft until comments are taken care of. |
|
@EricJohnson327 yes definitely we still want it! @AmelBawa-msft was making a bunch of changes though that will impact this flow so I was waiting until those PRs are merged in to work with Amir to add the functionality back in. |
|
Closing in favor of #2379 |
4 participants
Summary of the pull request
Files of type "*.winget" can launch Dev Home into the machine configuration flow.
Detailed description of the pull request / Additional comments
This PR adds logic into Dev Home to add ".winget" files as an activation handler so that users can launch directly into the Dev Home machine configuration flow by opening a ".winget" file with Dev Home.
Validation steps performed
PR checklist