pydevd: Fix up prefix of attach shared library for Windows #1939
Conversation
Follow-up to microsoft#1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
That I don't know, but there were some CI failures in #1917. Whether that's relevant - I'm not sure. |
|
Hmm, not sure why but either works for me locally. Oh no wait, it's only a problem on 3.11 and earlier. Sys monitoring doesn't use this method. |
rchiodo
left a comment
rchiodo
left a comment
There was a problem hiding this comment.
Thanks, I verified this change is required for attach in 3.11 and below on Windows.
rchiodo
left a comment
rchiodo
left a comment
There was a problem hiding this comment.
Thanks, I verified this change is required for attach in 3.11 and below on Windows.
|
Thanks for a quick turnaround - and sorry for messing up. A member of our community told me VSC's Python plugin is not using latest version of Debugpy just yet, so hopefully it won't have any consequences. |
* pydevd: Fix up prefix of attach shared library for Windows (#1939) Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment) * Check if `os.__file__` is available before using it (#1944) * check if os.file is available before using it * use threading.__file__ als last fallback * update testing for python 3.14 (#1955) * update testing for python 3.14 * Allow python 3.14 in attach code * move 3.14 to its own job outside of matrix * try 3.14.0-rc.2 * allowUnstable * use 3.14.0-rc.2 but use 3.14 in tests * include py.typed in the distributed package (#1960) * Add gcc flags (#1947) * Add pyrx-admins as code owners (#1976) * Add pyrx-admins as code owners * Combine CODEOWNERS entries into a single line --------- Co-authored-by: Piotr Osiewicz <[email protected]> Co-authored-by: timrid <[email protected]> Co-authored-by: Bill Schnurr <[email protected]> Co-authored-by: lev-blit <[email protected]> Co-authored-by: Karthik Nadig <[email protected]>
2 participants
Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)